fix(#2779): respect inbound TRACEPARENT in trace chain - #2833
Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
Closed
fix(#2779): respect inbound TRACEPARENT in trace chain#2833fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
When fullsend runs inside an instrumented pipeline that already exports TRACEPARENT, the runner now adopts the inbound trace-id (continuing the distributed trace chain) instead of generating a fresh one. The W3C trace-flags sampled bit is preserved so upstream sampling decisions are honored. The security trace-id is derived from the inbound trace-id via UUID reformatting. Additionally, childScriptEnv now filters any pre-existing TRACEPARENT from os.Environ() before appending, ensuring exactly one entry is present regardless of the parent environment. Shell interpolation guards (injectTraceID, buildScanContextCommand) use the new IsShellSafeTraceID validator that accepts any dashed-hex UUID format, not just UUID v4, since adopted trace-ids may have arbitrary version/variant bits. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Site previewPreview: https://01b387ed-site.fullsend-ai.workers.dev Commit: |
Member
|
Didn't mean to get this autocoded. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
🤖 Finished Retro · ✅ Success · Started 7:57 AM UTC · Completed 8:02 AM UTC |
Retro: PR #2833 — Unwanted autocoding from
|
dhshah13
added a commit
to dhshah13/fullsend
that referenced
this pull request
Jul 2, 2026
When a parent process exports TRACEPARENT (nested or instrumented invocation), fullsend now continues that trace instead of starting its own: the inbound trace-id becomes the unified security/W3C trace id, the inbound span-id is recorded as the root span's remote parent, and the inbound trace-flags are preserved through child-script TRACEPARENT, the recorder, and run-summary.json (previously hardcoded to sampled). childScriptEnv now filters any TRACEPARENT already present — inherited from the process environment or set in runner_env — so exactly one entry, fullsend's own, is seen by child scripts; env lookups resolve the first match, so a stale value used to shadow it. TRACESTATE passes through untouched. The shell-safety call sites switch to IsShellSafeTraceID since adopted ids are not UUID v4. The adoption logic lives in resolveTraceIdentity, a pure helper, so the behavior is unit-testable outside runAgent. Supersedes and ports fullsend-ai#2833 (closed unmerged for process reasons), adding the remote-parent record, summary flag fidelity, and W3C forward-compatible version parsing that the original missed. Signed-off-by: Dharit Shah <dhshah@redhat.com>
dhshah13
added a commit
to dhshah13/fullsend
that referenced
this pull request
Jul 2, 2026
When a parent process exports TRACEPARENT (nested or instrumented invocation), fullsend now continues that trace instead of starting its own: the inbound trace-id becomes the unified security/W3C trace id, the inbound span-id is recorded as the root span's remote parent, and the inbound trace-flags are preserved through child-script TRACEPARENT, the recorder, and run-summary.json (previously hardcoded to sampled). childScriptEnv now filters any TRACEPARENT already present — inherited from the process environment or set in runner_env — so exactly one entry, fullsend's own, is seen by child scripts; env lookups resolve the first match, so a stale value used to shadow it. TRACESTATE passes through untouched. The shell-safety call sites switch to IsShellSafeTraceID since adopted ids are not UUID v4. The adoption logic lives in resolveTraceIdentity, a pure helper, so the behavior is unit-testable outside runAgent. Supersedes and ports fullsend-ai#2833 (closed unmerged for process reasons), adding the remote-parent record, summary flag fidelity, and W3C forward-compatible version parsing that the original missed. Signed-off-by: Dharit Shah <dhshah@redhat.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fullsend runs inside an instrumented pipeline that already exports TRACEPARENT, the runner now adopts the inbound trace-id (continuing the distributed trace chain) instead of generating a fresh one. The W3C trace-flags sampled bit is preserved so upstream sampling decisions are honored. The security trace-id is derived from the inbound trace-id via UUID reformatting.
Additionally, childScriptEnv now filters any pre-existing TRACEPARENT from os.Environ() before appending, ensuring exactly one entry is present regardless of the parent environment.
Shell interpolation guards (injectTraceID, buildScanContextCommand) use the new IsShellSafeTraceID validator that accepts any dashed-hex UUID format, not just UUID v4, since adopted trace-ids may have arbitrary version/variant bits.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Closes #2779
Post-script verification
agent/2779-respect-inbound-traceparent)eb4cd140210bf3a65693a3c748889102b0ef5f6a..HEAD)