fix(#2797): create ready-for-triage label before use in post-retro.sh - #2800
Merged
Conversation
post-retro.sh passed --label "ready-for-triage" to gh issue create without ensuring the label existed in the target repo. This caused the retro workflow to fail with exit code 1 on repos that predate PR #2679 (which introduced the label in the scaffold template). Add a gh label create --force call before gh issue create, following the same idempotent pattern used in post-review.sh for the ready-for-merge and requires-manual-review labels. The --force flag makes the call a no-op when the label already exists. Also adds a mock handler for gh label create in the test harness and a test case verifying the label is created before the issue. Note: pre-commit could not run (shellcheck-py failed to install in sandbox due to network restrictions). Post-script runs an authoritative pre-commit check. Closes #2797
Site previewPreview: https://b41f8a79-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
rh-hemartin
approved these changes
Jul 1, 2026
|
🤖 Finished Retro · ✅ Success · Started 8:10 AM UTC · Completed 8:23 AM UTC |
Retro: PR #2800 — fix(#2797): create ready-for-triage label before use in post-retro.shWorkflow quality: Good. The code agent resolved this in a single iteration with clean code that follows existing patterns. Timeline
What went well
Gaps (already tracked)
ProposalsNo new proposals. All identified improvement opportunities are covered by existing open issues (#2674, #2739). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post-retro.sh passed --label "ready-for-triage" to gh issue create without ensuring the label existed in the target repo. This caused the retro workflow to fail with exit code 1 on repos that predate PR #2679 (which introduced the label in the scaffold template).
Add a gh label create --force call before gh issue create, following the same idempotent pattern used in post-review.sh for the ready-for-merge and requires-manual-review labels. The --force flag makes the call a no-op when the label already exists.
Also adds a mock handler for gh label create in the test harness and a test case verifying the label is created before the issue.
Note: pre-commit could not run (shellcheck-py failed to install in sandbox due to network restrictions). Post-script runs an authoritative pre-commit check.
Closes #2797
Post-script verification
agent/2797-retro-label-guard)dc93e9aed9efa125ba4fe35b381738729821dfa0..HEAD)