fix(#2632): use SKILL.md frontmatter name for remote skill display - #2633
Conversation
Remote skills loaded via URL were logged as "tree" during sandbox bootstrap because filepath.Base() on the cache path returns the last segment of GitHub's /tree/ URL convention. Add resolveSkillDisplayName() that reads SKILL.md frontmatter via skill.ParseFrontmatter() and uses the name field when available, falling back to filepath.Base() for local skills or when no frontmatter is present. Note: pre-commit could not run in sandbox (shellcheck network error). go vet and go test passed. Closes #2632
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
Site previewPreview: https://644b2de9-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
🤖 Finished Retro · ✅ Success · Started 9:09 PM UTC · Completed 9:17 PM UTC |
Retro: PR #2633 — fix remote skill display nameWorkflow quality: Excellent. This was a clean, efficient end-to-end workflow with zero rework cycles. Timeline
Total time: ~65 minutes (issue to merge). Code agent time: 7 minutes. Human review wait: ~38 minutes. What went well
Observation: no visible review agent activityNo review agent comment or review verdict was posted on this PR. The dispatch repo shows review.yml runs around the right timeframe (runs 28128704829 at 20:49 and 28128907845 at 20:53, both successful), but no corresponding comment appeared on the PR. It is unclear whether the review agent ran for this PR and chose not to post (by design for clean PRs), or whether it ran for a different PR. This is not necessarily a problem — the human reviewer approved it quickly — but it means there is no auditable trace of automated review for this change. Existing issues #1373 (post review on merged PRs) and #2619 (review status comment timing) are tangentially related but do not cover the specific gap of ensuring a visible review trace exists on every agent-authored PR. ProposalsOne proposal below addresses the review traceability gap. No other improvements are warranted — this workflow performed well across all optimization dimensions. Proposals filed
|
Remote skills loaded via URL were logged as "tree" during sandbox bootstrap because filepath.Base() on the cache path returns the last segment of GitHub's /tree/ URL convention. Add resolveSkillDisplayName() that reads SKILL.md frontmatter via skill.ParseFrontmatter() and uses the name field when available, falling back to filepath.Base() for local skills or when no frontmatter is present.
Note: pre-commit could not run in sandbox (shellcheck network error). go vet and go test passed.
Closes #2632
Post-script verification
agent/2632-skill-display-name)10b62b5510e1c8a22ed08ad0b1061aa346dd1373..HEAD)