Skip to content

fix(#2458): guard GITHUB_WORKSPACE in post-triage.sh for local execution - #2459

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/2458-guard-github-workspace-post-triage
Jun 22, 2026
Merged

fix(#2458): guard GITHUB_WORKSPACE in post-triage.sh for local execution#2459
rh-hemartin merged 1 commit into
mainfrom
agent/2458-guard-github-workspace-post-triage

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Apply ${GITHUB_WORKSPACE:-/tmp} fallback to the prerequisites handler (lines 133, 136) so post-triage.sh no longer crashes under set -u when run locally without GitHub Actions env vars. This matches the guard pattern already applied to pre-fetch-prior-review.sh and pre-code.sh in PR #2456.

Audited all other harness scripts — no remaining unguarded references.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Closes #2458

Post-script verification

  • Branch is not main/master (agent/2458-guard-github-workspace-post-triage)
  • Secret scan passed (gitleaks — 97a6e2440a512c23b7af7222f1fbbb1a94fba619..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Apply ${GITHUB_WORKSPACE:-/tmp} fallback to the prerequisites handler
(lines 133, 136) so post-triage.sh no longer crashes under set -u when
run locally without GitHub Actions env vars. This matches the guard
pattern already applied to pre-fetch-prior-review.sh and pre-code.sh
in PR #2456.

Audited all other harness scripts — no remaining unguarded references.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://abad8b49-site.fullsend-ai.workers.dev

Commit: 51ec19e22f84613df8151e552f05f2cea5f286af

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 19, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 12:06 PM UTC · Completed 12:15 PM UTC
Commit: 51ec19e · View workflow run →

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: PR fixes a bug in harness post-triage script.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge component/harness Agent harness, config, and skills loading type/bug Confirmed defect in existing behavior labels Jun 19, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Jun 22, 2026
Merged via the queue into main with commit 2250011 Jun 22, 2026
20 checks passed
@rh-hemartin
rh-hemartin deleted the agent/2458-guard-github-workspace-post-triage branch June 22, 2026 06:32
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 6:37 AM UTC · Completed 6:42 AM UTC
Commit: 51ec19e · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #2459 — guard GITHUB_WORKSPACE in post-triage.sh

Verdict: Clean workflow, no proposals.

This PR exemplifies the fullsend pipeline working as designed:

Stage Time Duration Result
Retro agent files #2458 from PR #2456 review finding 11:46 UTC Issue created
Triage 11:47–11:52 ~5 min Confirmed, ready-to-code
Code 11:53–12:02 ~9 min PR opened, 1 commit
Review 12:03–12:15 ~12 min Approved
Human approval (rh-hemartin) Jun 22 06:22 Approved
Merged Jun 22 06:32

Key observations:

  • Zero rework — code agent got it right on the first iteration (2 line fixes + 9 lines of test)
  • Good provenance — the retro agent correctly captured an out-of-scope review finding from PR fix(#2455): guard GITHUB_OUTPUT for local execution #2456 as a trackable issue, preventing it from being lost in PR comment history
  • Appropriate review — the review agent approved a minimal, pattern-matching fix without generating false-positive concerns
  • ~29 minutes from issue creation to fully-reviewed PR

No improvement proposals warranted.

ifireball pushed a commit to ifireball/fullsend that referenced this pull request Jun 24, 2026
…-github-workspace-post-triage

fix(fullsend-ai#2458): guard GITHUB_WORKSPACE in post-triage.sh for local execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/harness Agent harness, config, and skills loading ready-for-merge All reviewers approved — ready to merge type/bug Confirmed defect in existing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guard GITHUB_WORKSPACE in post-triage.sh for local execution

1 participant