Skip to content

fix(#2450): widen changelog scope regex and exclude merge commits - #2451

Merged
rh-hemartin merged 1 commit into
mainfrom
fix/2450-goreleaser-changelog
Jun 19, 2026
Merged

fix(#2450): widen changelog scope regex and exclude merge commits#2451
rh-hemartin merged 1 commit into
mainfrom
fix/2450-goreleaser-changelog

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The GoReleaser changelog group regexes used [[:word:]]+ for the scope, which only matches [A-Za-z0-9_]. Commits with # in the scope (e.g. fix(#2343): ...) bypassed group matching and fell to "Others". Replace with [^)]+ so any character except ) is accepted in the scope.

Also add '^Merge ' to filters.exclude so merge commits no longer appear under "Others" in release notes.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Closes #2450

Post-script verification

  • Branch is not main/master (fix/2450-goreleaser-changelog)
  • Secret scan passed (gitleaks — e66a42c38a458aedb7555db3daecd857584ecbae..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

The GoReleaser changelog group regexes used [[:word:]]+ for the scope,
which only matches [A-Za-z0-9_]. Commits with # in the scope (e.g.
fix(#2343): ...) bypassed group matching and fell to "Others". Replace
with [^)]+ so any character except ) is accepted in the scope.

Also add '^Merge ' to filters.exclude so merge commits no longer appear
under "Others" in release notes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://fd31463e-site.fullsend-ai.workers.dev

Commit: e766cb50de93cef64d8688e99a9311df79a136e8

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 19, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:42 AM UTC · Completed 6:49 AM UTC
Commit: e766cb5 · View workflow run →

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 19, 2026
@rh-hemartin rh-hemartin self-assigned this Jun 19, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Jun 19, 2026
Merged via the queue into main with commit 97a6e24 Jun 19, 2026
16 checks passed
@rh-hemartin
rh-hemartin deleted the fix/2450-goreleaser-changelog branch June 19, 2026 11:43
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 19, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 11:48 AM UTC · Completed 11:56 AM UTC
Commit: e766cb5 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #2451 — fix(#2450): widen changelog scope regex and exclude merge commits

This was a clean, efficient workflow. The code agent fixed GoReleaser changelog regex patterns in a single commit, the review agent approved correctly, and a human merged after ~5 hours.

Timeline: Issue #2450 created (06:22) → Triage (06:22–06:32, one cancelled by concurrency group, one succeeded) → Code agent (06:32–06:39, single commit) → Review agent approved (06:39–06:49) → Human approved (11:32) → Merged (11:43).

No new proposals. All potential improvements are already covered by existing open issues:

  • Redundant review dispatch after merge: A pull_request_review event from the human approval at 11:32 triggered review run 27823769621 at 11:45 — after the PR was already merged at 11:43. This is covered by #1870 (skip dispatch when PR is closed), #963 (skip when HEAD already approved), and #1125 (filter pull_request_review to only changes_requested).

  • Cancelled triage run: First triage run was superseded by concurrency group after ~40s of agent work. This is the system working as designed; issues #1014 and #981 track further debounce improvements.

  • Thin review comment: The review agent's "Looks good to me" is appropriate for a 3-line config regex fix. No action needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Goreleaser Changelog

1 participant