Skip to content

fix(#2348): stop swallowing gh pr create stderr in post-code.sh #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralphbean merged 1 commit into from
Jun 16, 2026
+5 −3
Merged

fix(#2348): stop swallowing gh pr create stderr in post-code.sh #2349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/scaffold/fullsend-repo/scripts/post-code.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,13 +406,15 @@ Closes #${ISSUE_NUMBER}
- [x] Pre-commit hooks passed (authoritative run on runner)
- [x] Tests ran inside sandbox"

PR_URL="$(gh pr create \
if ! PR_URL=$(gh pr create \
--repo "${REPO_FULL_NAME}" \
--head "${BRANCH}" \
--base "${TARGET_BRANCH}" \
--title "${PR_TITLE}" \
--body "${PR_BODY}" \
2>&1)"
--body "${PR_BODY}"); then
echo "::error::Failed to create PR: see above for details"

@fullsend-ai-review fullsend-ai-review Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] error-message-consistency

Error message 'Failed to create PR: see above for details' is less specific than the established pattern in reconcile-repos.sh, which uses 'Failed to create PR for $REPO'. The post-code.sh context has ISSUE_NUMBER and BRANCH available and could include them for faster log triage. However, since post-code.sh only has one PR creation call (unlike reconcile-repos.sh which loops), the generic message is less ambiguous here.

Suggested fix: Consider using 'Failed to create PR for issue #${ISSUE_NUMBER}' or 'Failed to create PR (branch: ${BRANCH})' to provide more context.

exit 1
fi

echo "PR created: ${PR_URL}"
echo "pr_url=${PR_URL}" >> "${GITHUB_OUTPUT:-/dev/null}"
Loading