fix(#2281): use inputs.target-repo in Go setup step - #2283
Conversation
The Go setup step added in PR #2213 hardcoded 'target-repo' in both the hashFiles condition and the go-version-file parameter. When inputs.target-repo is overridden to a custom path, hashFiles('target-repo/go.mod') returns empty, the if condition is false, and the step is silently skipped — defeating the purpose of the Go setup for non-default checkout paths. Apply the same fallback pattern used in the Run fullsend step: - hashFiles: use format() with inputs.target-repo fallback - go-version-file: use expression with fallback to default Note: pre-commit could not run (shellcheck hook failed to install due to network restrictions in sandbox). The post-script will run pre-commit authoritatively. Closes #2281
Site previewPreview: https://a00a952a-site.fullsend-ai.workers.dev Commit: |
|
/fs-fix Do not add a default value for it, other usages of inputs.target-repo do not use it. |
|
🤖 Review · |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🤖 Finished Fix · ✅ Success · Started 6:52 AM UTC · Completed 6:56 AM UTC |
Remove '|| target-repo' fallback from the hashFiles condition and go-version-file parameter to match how inputs.target-repo is used elsewhere in action.yml (line 362), where no inline default is applied. Addresses review feedback on #2283
🔧 Fix agent — iteration 1 (human-triggered)Removed the '|| target-repo' default fallback from both usages of inputs.target-repo in the Go setup step, per human instruction. Other usages of inputs.target-repo in action.yml do not use an inline default. Fixed (1):
Tests: passed Updated by fullsend fix agent |
|
🤖 Finished Review · ✅ Success · Started 6:59 AM UTC · Completed 7:09 AM UTC |
|
🤖 Finished Retro · ✅ Success · Started 7:07 AM UTC · Completed 7:14 AM UTC |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
|
Retro for PR #2283 — fix Timeline: Code agent opened the PR at 06:45 UTC with a correct fix (replacing hardcoded Root cause: The code agent didn't check how Existing issue overlap: #2030 covers reading sibling files for pattern consistency, but is scoped to sibling scripts in the same directory. This case is about same-file variable usage consistency, which is a distinct but related pattern. One proposal filed below to cover this gap. Proposals filed
|
The Go setup step added in PR #2213 hardcoded 'target-repo' in both the hashFiles condition and the go-version-file parameter. When inputs.target-repo is overridden to a custom path, hashFiles('target-repo/go.mod') returns empty, the if condition is false, and the step is silently skipped — defeating the purpose of the Go setup for non-default checkout paths.
Apply the same fallback pattern used in the Run fullsend step:
Note: pre-commit could not run (shellcheck hook failed to install due to network restrictions in sandbox). The post-script will run pre-commit authoritatively.
Closes #2281
Post-script verification
agent/2281-go-setup-target-repo)967a663ac165c4c0bebde778df677d4be81f3ee4..HEAD)