Skip to content

feat(resolve): add runtime fetch schema and ResolveSkillURL (Phase 4 PR 1) - #2103

Closed
ggallen wants to merge 1 commit into
fullsend-ai:mainfrom
ggallen:worktree-virtual-coalescing-whale
Closed

feat(resolve): add runtime fetch schema and ResolveSkillURL (Phase 4 PR 1)#2103
ggallen wants to merge 1 commit into
fullsend-ai:mainfrom
ggallen:worktree-virtual-coalescing-whale

Conversation

@ggallen

@ggallen ggallen commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Add allow_runtime_fetch and max_runtime_fetches fields to the harness schema with validation (negative max rejected, max without allow rejected, backward-compatible defaults)
  • Export ResolveSkillURL in internal/resolve/ for single-URL runtime skill resolution — reuses existing fetch/cache/integrity/SSRF infrastructure with FetchType: "runtime" audit logging
  • Add Phase 3 (backfill) and Phase 4 implementation plan docs; update Phase 1/2 plans with cross-references

This is PR 1 of 3 for Phase 4 (Runtime Dependency Loading) of ADR-0038. PR 2 adds the in-sandbox fullsend-fetch-skill script; PR 3 wires the runtime fetch handler into fullsend run.

Test plan

  • make go-test — all pass (5 new harness validation tests, 9 new ResolveSkillURL tests)
  • make lint — clean
  • Verify backward compatibility: harness without new fields loads and validates identically
  • Verify ResolveSkillURL paths: valid fetch, cache hit, hash mismatch, allowlist rejection, missing hash, non-HTTPS rejection, audit entry, offline miss/hit

🤖 Generated with Claude Code

…PR 1)

Add allow_runtime_fetch and max_runtime_fetches harness fields with
validation, and export ResolveSkillURL for single-URL runtime skill
resolution with SSRF protection, integrity verification, caching,
and "runtime" audit logging. Includes Phase 3/4 implementation plan
docs and cross-references from Phase 1/2 plans.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Greg Allen <gallen@redhat.com>
@ggallen ggallen closed this Jun 10, 2026
@ggallen
ggallen deleted the worktree-virtual-coalescing-whale branch June 10, 2026 00:11
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 10, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 12:12 AM UTC · Completed 12:23 AM UTC
Commit: 4ed6da4 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already closed.

The /fs-review command only reviews open pull requests.

Posted by fullsend pre-review check

@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 10, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 12:12 AM UTC · Completed 12:17 AM UTC
Commit: 4ed6da4 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

PR #2103 was a human-authored PR opened and closed within 26 seconds (likely reopened as PR #2104). The review agent was dispatched but correctly detected the closed state and skipped. This retro run itself is an example of unnecessary dispatch — no agent involvement, no review, no merge.

All improvement opportunities identified are already covered by existing open issues:

No new proposals are warranted. The existing issues, once implemented, would prevent both the unnecessary review dispatch and this retro run from occurring.

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already closed.

The /fs-review command only reviews open pull requests.

Posted by fullsend post-review check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant