chore: consolidate commit message guidance into COMMITS.md - #2089
Conversation
Agents were over-using the `feat` prefix for internal changes (refactors, dep bumps, prompt tuning) that aren't user-facing, bloating the Features section of release notes. COMMITS.md is now the single source of truth for commit message rules, with explicit guidance on when `feat` is appropriate vs `refactor` or `chore`. CLAUDE.md, AGENTS.md, and CONTRIBUTING.md now point to COMMITS.md instead of duplicating the specification inline. Refs: #2088 Signed-off-by: Ralph Bean <rbean@redhat.com> Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
|
Filed #2088 while working on this — the duplication between CLAUDE.md and AGENTS.md should be addressed separately. |
Site previewPreview: https://b53235a5-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 7:07 PM UTC · Completed 7:18 PM UTC |
ReviewFindingsMedium
Low
Info
|
|
🤖 Finished Retro · ✅ Success · Started 2:58 PM UTC · Completed 3:03 PM UTC |
Retro: PR #2089 — Consolidate commit message guidance into COMMITS.mdTimeline: Human-authored PR by ralphbean (2026-06-09). Review agent ran in ~12 minutes and found a legitimate medium-severity stale reference: Review quality: Good. The agent caught a real issue the PR author missed. The medium finding about Systemic pattern (already tracked): Medium-severity findings being merged without resolution is a known pattern covered by existing open issues: #1956 (auto-file tracking issues for unresolved medium+ findings), #2099 (alert when human approves with unresolved findings), and #870 (medium findings should trigger fix agent or block merge). No new proposal needed for this pattern. One concrete follow-up proposed: Fix the stale Proposals filed
|
Update the comment on line 9 of .gitlint from referencing CONTRIBUTING.md to COMMITS.md. PR fullsend-ai#2089 moved commit type documentation to COMMITS.md but missed this config comment. Note: pre-commit could not run in sandbox due to gitleaks hook installation failure (permission denied on go module cache). The post-script runs pre-commit authoritatively. Closes fullsend-ai#2125
Summary
COMMITS.mdas the single source of truth for commit message rules, including new guidance thatfeatis reserved for user-facing features (not internal refactors, dep bumps, or prompt tuning)Refs #2088
Test plan
make lintpasses