Add CONTRIBUTING.md and /renumber-adr skill - #207
Merged
Conversation
ralphbean
approved these changes
Apr 8, 2026
ralphbean
left a comment
Member
There was a problem hiding this comment.
Only question: should we encourage the use of make lint - does pre-commit accomplish the same thing?
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Marta Anon <manon@redhat.com>
maruiz93
force-pushed
the
contributing-guide
branch
from
April 8, 2026 23:46
73d5a08 to
d1ae12b
Compare
Contributor
Author
No, they don't do the same thing — but I think they should, so I consolidated them. Before this change, linting was split across two commands with different scopes: Neither was a superset of the other, so contributors had to know which to run when. Now all checks are pre-commit hooks, and make lint is just a shortcut for pre-commit run (staged changes). I also added make lint-all for running against every file, though I expect that'll be less commonly used. |
Member
|
Awesome! Thank you! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changes"
before merge
Motivation
We had no written guidance on PR review etiquette, which can lead to confusion about who resolves comments and how reviewers enforce their
feedback. Similarly, concurrent ADR PRs can collide on numbers — the new skill automates detection and renumbering so contributors don't have to
do it manually.