Skip to content

ci: add codecov configuration - #2064

Closed
eedri wants to merge 1 commit into
fullsend-ai:mainfrom
eedri:add-codecov-yml
Closed

ci: add codecov configuration#2064
eedri wants to merge 1 commit into
fullsend-ai:mainfrom
eedri:add-codecov-yml

Conversation

@eedri

@eedri eedri commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds .codecov.yml with standard coverage settings
  • Project coverage target: auto (threshold: 1%)
  • Patch coverage target: 80% (threshold: 5%)
  • Ignores non-code files: docs, hack, experiments, images, markdown, shell scripts

Reference

Based on konflux-ui/.codecov.yml

🤖 Generated with Claude Code

@fullsend-ai-review

Copy link
Copy Markdown

🤖 Review · Started 11:15 AM UTC
Commit: ba204cb · View workflow run →

Adds Codecov coverage configuration with:
- Project target: auto (threshold: 1%)
- Patch target: 80% (threshold: 5%)
- Ignores non-code files (docs, hack, experiments, images, markdown, shell)

Signed-off-by: Eyal Edri <eedri@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@eedri
eedri force-pushed the add-codecov-yml branch from c4685b7 to f4309eb Compare June 9, 2026 11:19
@ifireball
ifireball requested review from ifireball and ralphbean June 9, 2026 11:20
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:21 AM UTC · Completed 11:28 AM UTC
Commit: ba204cb · View workflow run →

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Site preview

Preview: https://e473ea18-site.fullsend-ai.workers.dev

Commit: f4309eb86e9e55b7e68243c38b885a22b6d8d84e

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [missing-authorization] .codecov.yml — Adding Codecov integration is a CI/CD configuration change with no linked issue. However, the file is inert without a corresponding Codecov GitHub App installation and CI upload step (neither exists in current workflows), making this low-risk. Consider filing an issue to track the rationale for Codecov adoption.

  • [architectural-justification] .codecov.yml — The project runs coverage via make go-test (go test -race -cover ./...) but has no coverage trend tracking. The PR does not explain what problem Codecov solves beyond existing coverage output.
    Remediation: Add a sentence to the PR description explaining the motivation (e.g., coverage trend tracking, PR-level coverage gating).

  • [path-pattern-inconsistency] .codecov.yml:19 — The ignore list includes **/*__data__*/*.ts but no __data__ directories exist in this repository. The repo does have testdata/ directories (e.g., skills/topissues/scripts/testdata/). The TypeScript pattern appears copied from the referenced konflux-ui config without adaptation.
    Remediation: Remove the **/*__data__*/*.ts pattern and consider adding **/testdata/** if test fixture files should be excluded from coverage.

Info

  • [scope-classification] .codecov.yml — Per CONTRIBUTING.md, this change should use the ci: or chore(ci): commit type under Conventional Commits. The PR title should follow this convention (e.g., ci: add codecov configuration).

  • [file-extension-inconsistency] .codecov.yml — New file uses .yml extension. The repository has a mixed pattern (.yml and .yaml both present). The .yml choice is acceptable and follows the majority pattern.

Comment thread .codecov.yml
@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 9, 2026
@ifireball

Copy link
Copy Markdown
Member

/fs-fix resolve the CI/lint issues

@ralphbean

Copy link
Copy Markdown
Member
image

@ralphbean

Copy link
Copy Markdown
Member

I'll fix the commit-lint failure (PR title needs a conventional commit prefix), clean up the stale __data__ ignore pattern, and add a codecov upload step to CI.

@ralphbean ralphbean changed the title Add .codecov.yml configuration ci: add codecov configuration Jun 9, 2026
@ralphbean

Copy link
Copy Markdown
Member

Superseded — reopening from the upstream branch with fixes applied.

@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 9, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 11:59 AM UTC · Completed 12:06 PM UTC
Commit: ba204cb · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #2064 — Add Codecov configuration

Workflow overview: eedri opened a fork PR adding .codecov.yml (Claude-assisted). The review agent ran, approved with low-severity findings, and applied ready-for-merge. CI commit-lint failed. ifireball issued /fs-fix but the dispatch was silently blocked (fork PR). ralphbean manually intervened, closed the PR, and opened PR #2069 with fixes.

Review quality was good. The review agent correctly identified: (1) a stale __data__ ignore pattern copied from another repo without adaptation, (2) missing conventional commit prefix, and (3) no linked issue. All three findings drove real fixes in the successor PR.

All improvement opportunities are already tracked:

  • Fix agent silent failure on fork PRs → #1920
  • Review agent approving despite CI failure → #369, #1424
  • ready-for-merge label on fork PRs from external contributors → #1464
  • Commit-lint as required status check → #1989

No new proposals filed. The existing issue backlog covers all gaps observed in this workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants