feat(web): add landing page, move doc graph to /graph.html - #1936
Conversation
9e55415 to
5e7c7e6
Compare
Site previewPreview: https://f516eedc-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsMedium
Low
Info
Previous runReviewFindingsMedium
Low
Info
|
waynesun09
left a comment
There was a problem hiding this comment.
Multi-Agent Review — 7 agents (2x claude-coder, 2x claude-researcher, 2x gemini, 1x cursor)
Findings: 2 HIGH, 5 MEDIUM (posted inline) · 5 LOW, 4 INFO (omitted from inline)
False positives removed: 5
Clean, well-executed PR. The two HIGH findings (missing SRI hashes, localStorage PAT scope) are pre-existing patterns carried from the old index.html — not regressions. The most actionable new issue is the docs-brand CSS missing text-decoration: none. The publicDir change warrants a conditional or comment.
See inline comments for details.
|
I won't fix anything to do with the graph, I'm just moving it. |
Replaces the document graph at / with a light-themed landing page that routes users to the docs SPA (/docs/) and the graph (/graph.html). - web/public/index.html: new landing page matching docs visual style - web/public/graph.html: doc graph moved from index.html - vite.config.ts: enable publicDir so dev server serves both files at root; add / → /index.html rewrite in spaFallbackPlugin - web/docs/src/App.svelte: brand link navigates back to / - .github/workflows/site-build.yml: bundle graph.html alongside index.html - docs/: update site-deployment.md, architecture.md, ADR 0019 to reflect new file layout Closes #549 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Hector Martinez <hemartin@redhat.com>
5e7c7e6 to
648ea47
Compare
waynesun09
left a comment
There was a problem hiding this comment.
Clean PR — well-scoped file move, landing page is visually consistent with the docs SPA, CI and documentation updates are thorough.
No blocking issues found.
waynesun09
left a comment
There was a problem hiding this comment.
One low-priority nit for a follow-up — see inline comment on graph.html.
Retro: PR #1936 — feat(web): add landing page, move doc graphWorkflow: Human-authored PR by What went well:
Main friction point:
Proposal assessment:
Proposals filed
|
Summary
/with a light-themed landing page consistent with the docs SPA visual style/to/graph.html/docs/and/graph.html; no admin link (dev paused)/vite.config.ts: enablespublicDirsonpm run devserves both files correctly; adds/→/index.htmlrewrite inspaFallbackPlugingraph.htmlalongsideindex.htmlarchitecture.md,site-deployment.mdupdated to reflect new file layoutCloses #549
Test plan
npm run dev→/shows landing page,/graph.htmlshows document graph,/docs/loads docs SPAnpm run buildsucceeds;web/dist/index.htmlandweb/dist/graph.htmlboth present_bundle/public/🤖 Generated with Claude Code