Skip to content

fix(images/code): run gopls install as sandbox user #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rh-hemartin merged 1 commit into from
Jun 8, 2026
Merged

fix(images/code): run gopls install as sandbox user #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions images/code/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,6 @@ RUN case "$TARGETARCH" in \
&& tar -C /usr/local -xzf /tmp/go.tar.gz \
&& rm /tmp/go.tar.gz

ENV PATH="/usr/local/go/bin:${PATH}" \
GOPATH="/sandbox/go" \
GOMODCACHE="/sandbox/go/pkg/mod"

# ---------------------------------------------------------------------------
# gopls — Go language server for Claude Code LSP code intelligence.
ARG GOPLS_VERSION=0.18.1
RUN GOBIN=/usr/local/go/bin go install "golang.org/x/tools/gopls@v${GOPLS_VERSION}" \
&& gopls version

# ---------------------------------------------------------------------------
# lychee — markdown link checker used by pre-commit hooks (lint-md-links).
# Baked into the image so pre-commit hooks work without network access.
Expand Down Expand Up @@ -122,3 +112,9 @@ COPY scan-secrets /usr/local/bin/scan-secrets
RUN chmod +x /usr/local/bin/scan-secrets

USER sandbox

# ---------------------------------------------------------------------------
# gopls — Go language server for Claude Code LSP code intelligence.
ENV PATH="/sandbox/go/bin:/usr/local/go/bin:${PATH}"
ARG GOPLS_VERSION=0.18.1
RUN go install "golang.org/x/tools/gopls@v${GOPLS_VERSION}" && gopls version
8 changes: 4 additions & 4 deletions internal/cli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ import (
"github.com/fullsend-ai/fullsend/internal/envfile"
"github.com/fullsend-ai/fullsend/internal/fetch"
"github.com/fullsend-ai/fullsend/internal/harness"
agentruntime "github.com/fullsend-ai/fullsend/internal/runtime"
"github.com/fullsend-ai/fullsend/internal/resolve"
agentruntime "github.com/fullsend-ai/fullsend/internal/runtime"
"github.com/fullsend-ai/fullsend/internal/sandbox"
"github.com/fullsend-ai/fullsend/internal/scaffold"
"github.com/fullsend-ai/fullsend/internal/security"
Expand Down Expand Up @@ -872,10 +872,10 @@ func bootstrapEnv(sandboxName, repoDir string, h *harness.Harness, runtimeEnvExp

// Infrastructure vars.
pathExport := fmt.Sprintf("export PATH=%s/bin", sandbox.SandboxWorkspace)
if len(h.Plugins) > 0 {
pathExport += ":/usr/local/go/bin"
}
pathExport += ":/usr/local/go/bin"
pathExport += ":$HOME/go/bin"
pathExport += ":$PATH"

lines = append(lines, pathExport)
lines = append(lines, runtimeEnvExports...)
lines = append(lines, fmt.Sprintf("export FULLSEND_OUTPUT_DIR=%s", outputDir))
Expand Down
Loading