Skip to content

feat(#1885): add diff-size calibration to review sub-agents - #1903

Merged
ben-alkov merged 3 commits into
mainfrom
agent/1885-sub-agent-diff-calibration
Jun 4, 2026
Merged

feat(#1885): add diff-size calibration to review sub-agents#1903
ben-alkov merged 3 commits into
mainfrom
agent/1885-sub-agent-diff-calibration

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The style and intent sub-agents applied uniform investigation depth regardless of diff size, causing excessive tool calls on trivial changes (e.g., 59 tool calls for a 4-line YAML digest swap).

Style sub-agent (style-conventions.md):

  • Raise trivial diff threshold from 10 to 20 lines
  • Prohibit reading files outside changed directories
  • Prohibit shell pipelines (awk/sed) for formatting analysis
  • Prohibit git log/blame searches on trivial diffs
  • Add value-only diff category with early-exit guidance

Intent sub-agent (intent-coherence.md):

  • Add diff-size-aware investigation depth section
  • Skip CLAUDE.md/AGENTS.md/ADR reads for value-only changes
  • Treat mechanical changes without linked issues as implicitly
    authorized
  • Add revert PR recognition (revert-* branch, Revert "..."
    commit/title) as self-authorizing for scope
  • Focus revert review on completeness and extra changes

Note: make lint and go test could not run due to sandbox Go toolchain permission error (unrelated to this change). Manual verification required.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Closes #1885

Post-script verification

  • Branch is not main/master (agent/1885-sub-agent-diff-calibration)
  • Secret scan passed (gitleaks — 7e768afe50ea067e39066e4adc5451f22f85cec0..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

The style and intent sub-agents applied uniform investigation
depth regardless of diff size, causing excessive tool calls on
trivial changes (e.g., 59 tool calls for a 4-line YAML digest
swap).

Style sub-agent (style-conventions.md):
- Raise trivial diff threshold from 10 to 20 lines
- Prohibit reading files outside changed directories
- Prohibit shell pipelines (awk/sed) for formatting analysis
- Prohibit git log/blame searches on trivial diffs
- Add value-only diff category with early-exit guidance

Intent sub-agent (intent-coherence.md):
- Add diff-size-aware investigation depth section
- Skip CLAUDE.md/AGENTS.md/ADR reads for value-only changes
- Treat mechanical changes without linked issues as implicitly
  authorized
- Add revert PR recognition (revert-* branch, Revert "..."
  commit/title) as self-authorizing for scope
- Focus revert review on completeness and extra changes

Note: make lint and go test could not run due to sandbox Go
toolchain permission error (unrelated to this change). Manual
verification required.

Closes #1885

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Site preview

Preview: https://c56b6ae1-site.fullsend-ai.workers.dev

Commit: a104165b8825070481c6dfd372376044ff498893

ben-alkov
ben-alkov previously approved these changes Jun 4, 2026

@ben-alkov ben-alkov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ben-alkov ben-alkov self-assigned this Jun 4, 2026
@ben-alkov

Copy link
Copy Markdown
Member

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review

Findings

Low

  • [privilege-escalation-via-prompt-manipulation] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — The revert PR verification requires at least two metadata signals AND diff-inverse verification, which substantially mitigates bypass risk. However, the verification is performed by the same LLM agent being instructed, and the criteria ("changed files and hunks reverse the original change") leave room for loose interpretation. A near-revert that reverses most hunks but slips in a small addition could pass a cursory check. This is a meaningful improvement over the prior state but not a deterministic control. See also: [design-direction] finding at this location.

  • [design-direction] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:47 — Revert PR detection and verification lives entirely in the intent sub-agent. If other sub-agents later need revert awareness (e.g., correctness adjusting investigation depth for reverts), the logic would need to be duplicated. Consider moving revert classification to the orchestrator's triage phase (SKILL.md step 3) so sub-agents receive a pr_type: revert flag in their context package. See also: [privilege-escalation-via-prompt-manipulation] finding at this location.

Info

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:30 — Prior low-severity [edge-case] finding about asymmetry between trivial and non-trivial tiers for missing issue links is resolved: the non-trivial tier now explicitly states "If there is no linked issue, flag a missing-authorization finding."

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md — Three prior low-severity findings all resolved: [section-naming] heading renamed to "Revert PR authorization"; [instruction-specificity] clarified to "the directory of each changed file"; [section-naming] heading shortened to "Early exit criteria".

  • [design-direction] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md:22 — The trivial-diff threshold (20 changed lines) is consistent across both sub-agents but not anchored to project-wide architectural guidance. Consider documenting diff-size classification thresholds in a central location so they can be adjusted in one place.

Previous run

Review

Findings

Low

  • [privilege-escalation-via-prompt-manipulation] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — The revert PR verification now requires at least two metadata signals AND diff-inverse verification, which substantially mitigates the prior high-severity finding. However, the verification is performed by the same LLM agent being instructed, and the criteria ("changed files and hunks reverse the original change") leave room for loose interpretation. A near-revert that reverses most hunks but slips in a small addition could pass a cursory check. This is a meaningful improvement over the prior state but not a deterministic control. See also: [design-direction] finding at this location.

  • [edge-case] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:30 — The trivial-diff tier explicitly handles missing issue links (report info-level finding for mechanical changes), but the non-trivial tier only says "If the PR has a linked issue, read the issue to establish authorized scope" without specifying what to do when no issue is linked on a non-trivial diff. The agent's general "Own" block covers scope authorization, so this is unlikely to cause incorrect behavior, but the asymmetry between tiers could be confusing.

  • [design-direction] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:47 — Revert PR detection and verification lives entirely in the intent sub-agent. If other sub-agents later need revert awareness, the logic would need to be duplicated. Consider moving revert classification to the orchestrator's triage phase (SKILL.md step 3) so sub-agents receive a pr_type: revert flag in their context package. This is a future improvement, not a flaw in the current implementation. See also: [privilege-escalation-via-prompt-manipulation] finding at this location.

  • [section-naming] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:27 — The "Revert PRs" heading names the subject but not the action, unlike sibling headings ("Exploration budget", "Early exit for mechanical and value-only changes"). Consider "Revert PR authorization" or "Handling revert PRs" for consistency.

  • [instruction-specificity] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md:24 — "Do not read files outside the directories containing changed files" is ambiguous for multi-directory PRs. The trivial-diff context (single concern) makes this unlikely to cause issues, but clarifying to "the directory of each changed file" would be more precise.

  • [section-naming] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md:41 — The heading "Early exit for mechanical and value-only changes" is long (56 chars) compared to sibling headings. Consider shortening to "Early exit criteria" since the body enumerates change types.

Info

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — Prior high-severity [privilege-escalation-via-prompt-manipulation] finding is substantially mitigated: now requires 2-of-3 metadata signals plus diff-inverse verification. Downgraded from high to low.

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:31 — Prior medium-severity [authorization-bypass-via-scope-classification] finding is resolved: "report no findings" replaced with "report an info-level finding noting that authorization was inferred."

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:20 — Prior medium-severity [naming-convention] finding is resolved: both files now use "Exploration budget" as the section heading.

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md — Prior low-severity [edge-case] finding about overlap between "Value-only diffs" and "Early exit" sections is resolved: sections merged with explicit precedence rule.

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — Prior low-severity [edge-case] finding about revert heuristic ambiguity resolved: now explicitly requires "at least two" signals.

Previous run

Review

Findings

Low

  • [privilege-escalation-via-prompt-manipulation] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — The revert PR verification now requires at least two metadata signals AND diff-inverse verification, which substantially mitigates the prior high-severity finding. However, the verification is performed by the same LLM agent being instructed, and the criteria ("changed files and hunks reverse the original change") leave room for loose interpretation. A near-revert that reverses most hunks but slips in a small addition could pass a cursory check. This is a meaningful improvement over the prior state but not a deterministic control. See also: [design-direction] finding at this location.

  • [edge-case] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:30 — The trivial-diff tier explicitly handles missing issue links (report info-level finding for mechanical changes), but the non-trivial tier only says "If the PR has a linked issue, read the issue to establish authorized scope" without specifying what to do when no issue is linked on a non-trivial diff. The agent's general "Own" block covers scope authorization, so this is unlikely to cause incorrect behavior, but the asymmetry between tiers could be confusing.

  • [design-direction] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:47 — Revert PR detection and verification lives entirely in the intent sub-agent. If other sub-agents later need revert awareness, the logic would need to be duplicated. Consider moving revert classification to the orchestrator's triage phase (SKILL.md step 3) so sub-agents receive a pr_type: revert flag in their context package. This is a future improvement, not a flaw in the current implementation. See also: [privilege-escalation-via-prompt-manipulation] finding at this location.

  • [section-naming] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:27 — The "Revert PRs" heading names the subject but not the action, unlike sibling headings ("Exploration budget", "Early exit for mechanical and value-only changes"). Consider "Revert PR authorization" or "Handling revert PRs" for consistency.

  • [instruction-specificity] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md:24 — "Do not read files outside the directories containing changed files" is ambiguous for multi-directory PRs. The trivial-diff context (single concern) makes this unlikely to cause issues, but clarifying to "the directory of each changed file" would be more precise.

  • [section-naming] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md:41 — The heading "Early exit for mechanical and value-only changes" is long (56 chars) compared to sibling headings. Consider shortening to "Early exit criteria" since the body enumerates change types.

Info

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — Prior high-severity [privilege-escalation-via-prompt-manipulation] finding is substantially mitigated: now requires 2-of-3 metadata signals plus diff-inverse verification. Downgraded from high to low.

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:31 — Prior medium-severity [authorization-bypass-via-scope-classification] finding is resolved: "report no findings" replaced with "report an info-level finding noting that authorization was inferred."

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:20 — Prior medium-severity [naming-convention] finding is resolved: both files now use "Exploration budget" as the section heading.

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md — Prior low-severity [edge-case] finding about overlap between "Value-only diffs" and "Early exit" sections is resolved: sections merged with explicit precedence rule.

  • [prior-finding-resolved] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — Prior low-severity [edge-case] finding about revert heuristic ambiguity resolved: now explicitly requires "at least two" signals.

Previous run (2)

Review

Findings

High

  • [privilege-escalation-via-prompt-manipulation] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — Revert PR detection relies entirely on attacker-controllable PR metadata (branch name matching revert-*, commit message/title matching Revert "..."). Any PR author can craft these signals while introducing arbitrary new code. The agent would then skip missing-authorization and unauthorized-change checks because the PR is classified as a "clean revert," bypassing scope authorization for novel, unauthorized changes. While correctness and security sub-agents still review the code independently (defense in depth), scope authorization is specifically the intent sub-agent's responsibility and would be circumvented. See also: [edge-case] finding at this location regarding detection ambiguity.
    Remediation: Add a verification step requiring the agent to confirm the diff is an actual revert — e.g., by checking that changed files and hunks are the inverse of a specific prior merged commit (referenced from the revert commit message), or by requiring that revert PRs still link to an issue or carry an explicit maintainer label before skipping authorization checks.

Medium

  • [authorization-bypass-via-scope-classification] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:31 — For trivial diffs without a linked issue, the instruction states "scope authorization is implicit — report no findings" when the change is deemed mechanical. Whether a change qualifies as mechanical is a subjective judgment the agent makes from the diff alone. An attacker could disguise a small but impactful change as a mechanical update, and the agent would skip authorization review. Other sub-agents provide defense in depth, but the intent sub-agent's scope check would be bypassed.
    Remediation: Remove the blanket "report no findings" directive. Instead, instruct the agent to still note that authorization was inferred (as an info-level finding) rather than silently skipping, so the orchestrator has visibility.

  • [naming-convention] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md:18 / internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:20 — The two files modified in this PR use different section heading names for the same concept: "Exploration budget" (style-conventions.md, pre-existing) vs. "Investigation depth" (intent-coherence.md, new). Both sections serve the same purpose — calibrating tool usage to diff size. The naming divergence was introduced by this PR.
    Remediation: Align section headings across both files. Choose either "Investigation depth" or "Exploration budget" and apply consistently.

Low

  • [edge-case] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md — The new "Value-only diffs" section overlaps with the existing "Early exit for mechanical changes" section that remains after the patch. Both cover the same scenario (dependency version bumps, digest swaps) with the same outcome (report no findings, no further exploration). Consolidating or cross-referencing them would eliminate the redundancy.

  • [edge-case] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:39 — The revert PR detection lists three heuristics (branch name, commit message, PR title) without specifying whether ALL must match or ANY one is sufficient. GitHub auto-generated reverts satisfy all three, but manually constructed reverts might match only one. Since the consequence is skipping authorization checks, this ambiguity matters. See also: [privilege-escalation-via-prompt-manipulation] finding at this location.

  • [design-smell] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md:20 — The "under 20 changed lines" threshold creates an off-by-one ambiguity: does exactly 20 lines fall into trivial or non-trivial? Both files use the same phrasing, so at least they are consistent with each other.

Info

  • [section-ordering] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md:36 — The new "Value-only diffs" section is characterized as "any size" which overlaps with both trivial and non-trivial categories. A 25-line value-only change could match either "Value-only" or "Non-trivial" guidance. Consider clarifying precedence.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md Outdated
Comment thread internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md Outdated
@ben-alkov

Copy link
Copy Markdown
Member

/fs-fix

- Require diff-inverse verification for revert PRs, not just metadata signals
- Require at least two revert signals (branch, commit msg, title) to match
- Replace silent "report no findings" with info-level finding for inferred auth
- Align section heading to "Exploration budget" across both sub-agents
- Consolidate "Value-only diffs" into "Early exit for mechanical changes"
- Add precedence note for value-only changes vs size-based categories

Addresses review feedback on #1903

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: fullsend-fix <fullsend-code@users.noreply.github.com>
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 1 (human-triggered)

Addressed 6 of 7 review findings. The high-severity privilege-escalation finding was fixed by requiring diff-inverse verification and multiple metadata signals for revert PRs. The authorization-bypass finding was fixed by replacing silent skip with an info-level finding. Naming inconsistency was aligned to Exploration budget. Value-only/mechanical sections were consolidated with a precedence note. Disagreed with 1 finding (off-by-one ambiguity) as the phrasing is unambiguous.

Fixed (6):

  1. privilege-escalation-via-prompt-manipulation: revert PR detection relies on attacker-controllable metadata (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md): Added diff-inverse verification requirement: agent must confirm the diff reverses a specific prior merged commit before skipping authorization checks. If verification fails, standard authorization applies.
  2. authorization-bypass-via-scope-classification: silent skip of authorization for mechanical changes (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md): Changed 'report no findings' to 'report an info-level finding noting authorization was inferred' so the orchestrator has visibility into the decision.
  3. naming-convention: Exploration budget vs Investigation depth heading inconsistency (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md): Renamed Investigation depth to Exploration budget to match style-conventions.md pre-existing heading.
  4. edge-case: Value-only diffs overlaps with Early exit for mechanical changes (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md): Consolidated the two sections into Early exit for mechanical and value-only changes, merging examples and eliminating redundancy.
  5. edge-case: revert PR detection ambiguity (ANY vs ALL match) (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md): Specified that at least two of three signals must match for candidate revert status, since any single signal is attacker-controllable.
  6. section-ordering: Value-only diffs size overlap with trivial/non-trivial categories (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md): Resolved by consolidating value-only into the early-exit section and adding an explicit precedence note: value-only changes exit early regardless of line count.

Disagreed (1):

  1. design-smell: off-by-one ambiguity with under 20 threshold: The phrasing is unambiguous: under 20 means less than 20 and 20+ means 20 or more. Both files use the same phrasing, and the boundary is consistent. No change needed.

Tests: passed

Updated by fullsend fix agent

Comment thread internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md Outdated
@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 4, 2026
@ben-alkov
ben-alkov self-requested a review June 4, 2026 19:34
@ben-alkov
ben-alkov dismissed their stale review June 4, 2026 19:44

Can't trigger fs-fix

@ben-alkov ben-alkov added agent/fix Fix agent and removed ready-for-merge All reviewers approved — ready to merge agent/fix Fix agent labels Jun 4, 2026
@ben-alkov

Copy link
Copy Markdown
Member

/fs-fix

- Add explicit missing-authorization guidance for non-trivial diffs
  without linked issues (edge-case finding)
- Rename "Revert PRs" to "Revert PR authorization" for heading
  consistency (section-naming finding)
- Clarify "directory of each changed file" for multi-directory PRs
  (instruction-specificity finding)
- Shorten "Early exit for mechanical and value-only changes" to
  "Early exit criteria" (section-naming finding)

Addresses review feedback on #1903

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: fullsend-fix <fullsend-code@users.noreply.github.com>
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 2 (human-triggered)

Addressed 4 of 6 low-severity review findings with targeted fixes. Disagreed with 2 findings: design-direction (out of scope future improvement) and privilege-escalation residual (no actionable fix for LLM verification limitation).

Fixed (4):

  1. edge-case: non-trivial tier missing guidance for no linked issue (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md): Added explicit instruction to flag missing-authorization when non-trivial diffs lack a linked issue, resolving the asymmetry with the trivial tier.
  2. section-naming: Revert PRs heading inconsistent with sibling headings (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/intent-coherence.md): Renamed 'Revert PRs' to 'Revert PR authorization' to follow the action-oriented naming pattern of sibling headings.
  3. instruction-specificity: directories containing changed files is ambiguous (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md): Clarified to 'the directory of each changed file' for precision with multi-directory PRs.
  4. section-naming: Early exit heading too long (internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/style-conventions.md): Shortened 'Early exit for mechanical and value-only changes' to 'Early exit criteria' since the body enumerates change types.

Disagreed (2):

  1. design-direction: move revert classification to orchestrator triage phase: The reviewer explicitly noted this is a future improvement, not a flaw in the current implementation. Moving revert logic to the orchestrator would change the PR's scope and require modifying SKILL.md, which is outside this PR's purpose.
  2. privilege-escalation-via-prompt-manipulation: LLM verification is not deterministic: The reviewer acknowledged this is a meaningful improvement over the prior state. The finding notes a theoretical limitation of LLM-based verification, not an actionable code change. No deterministic alternative exists within the sub-agent instruction format.

Tests: passed

Updated by fullsend fix agent

@ben-alkov
ben-alkov added this pull request to the merge queue Jun 4, 2026

## Revert PR authorization

A PR is a candidate revert if **at least two** of the following signals

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] design-direction

Revert PR detection and verification lives entirely in the intent sub-agent. If other sub-agents later need revert awareness, the logic would need to be duplicated. Consider moving revert classification to the orchestrator's triage phase so sub-agents receive a pr_type: revert flag in their context package.

Before exploring context files, assess the diff size and nature.

**Trivial diffs (under 10 changed lines, single concern):**
**Trivial diffs (under 20 changed lines, single concern):**

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info] design-direction

The trivial-diff threshold (20 changed lines) is consistent across both sub-agents but not anchored to project-wide architectural guidance. Consider documenting diff-size classification thresholds in a central location.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 4, 2026
Merged via the queue into main with commit 90eef20 Jun 4, 2026
10 of 12 checks passed
@ben-alkov
ben-alkov deleted the agent/1885-sub-agent-diff-calibration branch June 4, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review sub-agents should scale investigation depth to diff size and complexity

1 participant