Skip to content

refactor!: rename --source-org flag to --app-set in mint enroll - #1677

Merged
waynesun09 merged 2 commits into
mainfrom
rename-source-org-to-app-set
May 29, 2026
Merged

refactor!: rename --source-org flag to --app-set in mint enroll#1677
waynesun09 merged 2 commits into
mainfrom
rename-source-org-to-app-set

Conversation

@waynesun09

@waynesun09 waynesun09 commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Renames --source-org to --app-set in mint enroll commands, converging on the same naming convention used by admin install
  • Uses appsetup.DefaultAppSet constant and appsetup.ValidateAppSet() validator, matching the admin command path
  • Updates tests (including new self-enroll coverage), docs, and SKILL.md runbook scripts

BREAKING CHANGE: --source-org flag removed, use --app-set instead.

Test plan

  • make go-test — all tests pass
  • make go-vet — clean
  • grep -rn 'source.org' internal/cli/mint.go — zero results
  • grep -rn 'source-org' internal/cli/ docs/ skills/ — zero results
  • ./bin/fullsend mint enroll --help — shows --app-set flag with correct default
  • 10-agent review squad — all findings addressed

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown

Site preview

Preview: https://dd65f996-site.fullsend-ai.workers.dev

Commit: 02cbeb0bbe1f97701d10fc6088ca6238ffe540ab

@fullsend-ai-review

fullsend-ai-review Bot commented May 28, 2026

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] skills/mint-enroll/SKILL.md — This PR modifies a file under the skills/ protected path. No linked issue provides authorization for this change. The SKILL.md updates are consistent with the flag rename (updating runbook scripts from SOURCE_ORG to APP_SET), but human approval is required for all protected-path changes and a linked issue should justify the modification.
    Remediation: Link an authorizing issue to this PR that covers the --source-org--app-set rename, including the SKILL.md runbook updates.
Previous run

Review

Findings

High

  • [protected-path] skills/mint-enroll/SKILL.md — This PR modifies a file under the skills/ protected path. No linked issue provides authorization for this change. The SKILL.md updates are consistent with the flag rename (updating runbook scripts from SOURCE_ORG to APP_SET), but human approval is required for all protected-path changes and a linked issue should justify the modification.
    Remediation: Link an authorizing issue to this PR that covers the --source-org--app-set rename, including the SKILL.md runbook updates.
Previous run

Review

Findings

High

  • [protected-path] skills/mint-enroll/SKILL.md — This PR modifies a file under the skills/ protected path. No linked issue provides authorization for this change. The SKILL.md updates are consistent with the flag rename (updating runbook scripts from SOURCE_ORG to APP_SET), but human approval is required for all protected-path changes and a linked issue should justify the modification.
    Remediation: Link an authorizing issue to this PR that covers the --source-org--app-set rename, including the SKILL.md runbook updates.

Low

  • [documentation-currency] docs/guides/admin/installation.md:185 — This line still refers to "the source org" when describing PEM secret copying. The same file already uses --app-set terminology two lines later (line 187), creating an inconsistency. Since the PR renames the concept from "source org" to "app set" across the codebase, this reference is now stale.
    Remediation: Update line 185 to use "app set" terminology (e.g., "It copies PEM secrets from the app set to the new org's scoped key").
Previous run

Review

Findings

High

  • [protected-path] skills/mint-enroll/SKILL.md — This PR modifies a file under the skills/ protected path. No linked issue provides authorization for this change. The SKILL.md updates are consistent with the flag rename (updating runbook scripts from SOURCE_ORG to APP_SET), but human approval is required for all protected-path changes and a linked issue should justify the modification.
    Remediation: Link an authorizing issue to this PR that covers the --source-org--app-set rename, including the SKILL.md runbook updates.
Previous run (2)

Review

Findings

High

  • [protected-path] skills/mint-enroll/SKILL.md — This PR modifies a file under the skills/ protected path. No linked issue provides authorization for this change. The SKILL.md updates are consistent with the flag rename (updating runbook scripts from SOURCE_ORG to APP_SET), but human approval is required for all protected-path changes and a linked issue should justify the modification.
    Remediation: Link an authorizing issue to this PR that covers the --source-org--app-set rename, including the SKILL.md runbook updates.

Low

  • [documentation-currency] docs/guides/admin/installation.md:185 — This line still refers to "the source org" when describing PEM secret copying. The same file already uses --app-set terminology two lines later (line 187), creating an inconsistency. Since the PR renames the concept from "source org" to "app set" across the codebase, this reference is now stale.
    Remediation: Update line 185 to use "app set" terminology (e.g., "It copies PEM secrets from the app set to the new org's scoped key").

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@waynesun09
waynesun09 force-pushed the rename-source-org-to-app-set branch from 0e3c211 to 2dffc7b Compare May 28, 2026 21:53
@waynesun09 waynesun09 changed the title refactor: rename --source-org flag to --app-set in mint enroll refactor!: rename --source-org flag to --app-set in mint enroll May 28, 2026
@ifireball

Copy link
Copy Markdown
Member

Not sure how neccessray this PR is, I think we need to drop the support for multiple app sets from the mint soon (preferably before I finish the public mint ADRs so I don't have to deal with that extra functionality in them).

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Converge on --app-set naming used by admin install, with the same
default (appsetup.DefaultAppSet) and validation (ValidateAppSet).

BREAKING CHANGE: --source-org flag removed, use --app-set instead.

Signed-off-by: Wayne Sun <gsun@redhat.com>
Registers --source-org as a hidden, deprecated Cobra flag that forwards
to --app-set, so existing automation gets a deprecation warning instead
of a hard "unknown flag" error. Adds test coverage for the alias and a
clarifying comment on the self-enroll test.

Signed-off-by: Wayne Sun <gsun@redhat.com>

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@waynesun09

Copy link
Copy Markdown
Member Author

This is a step toward decoupling from a specific org name — the concept is really an "app set" (a logical grouping of GitHub App installations), not necessarily tied to any particular GitHub org.

That said, this rename is not about stripping out the ability to create app sets or letting users bring their own mint service. It's just a terminology alignment so the flag name reflects what it actually represents.

Agree that simplifying multi-app-set support is a separate conversation worth having before the public mint ADRs land.

@waynesun09
waynesun09 added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit ae3881b May 29, 2026
10 checks passed
@waynesun09
waynesun09 deleted the rename-source-org-to-app-set branch May 29, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants