refactor!: rename --source-org flag to --app-set in mint enroll - #1677
Conversation
Site previewPreview: https://dd65f996-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsHigh
Previous runReviewFindingsHigh
Previous runReviewFindingsHigh
Low
Previous runReviewFindingsHigh
Previous run (2)ReviewFindingsHigh
Low
|
0e3c211 to
2dffc7b
Compare
|
Not sure how neccessray this PR is, I think we need to drop the support for multiple app sets from the mint soon (preferably before I finish the public mint ADRs so I don't have to deal with that extra functionality in them). |
Converge on --app-set naming used by admin install, with the same default (appsetup.DefaultAppSet) and validation (ValidateAppSet). BREAKING CHANGE: --source-org flag removed, use --app-set instead. Signed-off-by: Wayne Sun <gsun@redhat.com>
Registers --source-org as a hidden, deprecated Cobra flag that forwards to --app-set, so existing automation gets a deprecation warning instead of a hard "unknown flag" error. Adds test coverage for the alias and a clarifying comment on the self-enroll test. Signed-off-by: Wayne Sun <gsun@redhat.com>
2dffc7b to
02cbeb0
Compare
|
This is a step toward decoupling from a specific org name — the concept is really an "app set" (a logical grouping of GitHub App installations), not necessarily tied to any particular GitHub org. That said, this rename is not about stripping out the ability to create app sets or letting users bring their own mint service. It's just a terminology alignment so the flag name reflects what it actually represents. Agree that simplifying multi-app-set support is a separate conversation worth having before the public mint ADRs land. |
Summary
--source-orgto--app-setinmint enrollcommands, converging on the same naming convention used byadmin installappsetup.DefaultAppSetconstant andappsetup.ValidateAppSet()validator, matching the admin command pathBREAKING CHANGE:
--source-orgflag removed, use--app-setinstead.Test plan
make go-test— all tests passmake go-vet— cleangrep -rn 'source.org' internal/cli/mint.go— zero resultsgrep -rn 'source-org' internal/cli/ docs/ skills/— zero results./bin/fullsend mint enroll --help— shows--app-setflag with correct default