fix(#1619): guard grep pipeline in pre-fetch-prior-review.sh - #1620
Merged
Conversation
The SHA extraction grep on line 82 of pre-fetch-prior-review.sh exits with code 1 when the prior review comment body lacks a **Head SHA:** pattern. Under set -euo pipefail, this crashes the entire pre-fetch step, aborting the review run before the agent starts. Append `|| true` to the grep pipeline so an empty PRIOR_SHA is treated as a valid first-review case (the existing fallback on lines 83-84 already handles empty SHA gracefully). Also adds pre-fetch-prior-review-test.sh covering: no prior review, valid SHA extraction, missing SHA (the crash case), full 40-char SHA, and SHA only in sticky history section. Closes #1619 Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
Site previewPreview: https://1c453359-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
rh-hemartin
approved these changes
Jun 1, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SHA extraction grep on line 82 of pre-fetch-prior-review.sh exits with code 1 when the prior review comment body lacks a
Head SHA: pattern. Under set -euo pipefail, this crashes
the entire pre-fetch step, aborting the review run before the agent starts.
Append
|| trueto the grep pipeline so an empty PRIOR_SHA is treated as a valid first-review case (the existing fallback on lines 83-84 already handles empty SHA gracefully).Also adds pre-fetch-prior-review-test.sh covering: no prior review, valid SHA extraction, missing SHA (the crash case), full 40-char SHA, and SHA only in sticky history section.
Closes #1619
Post-script verification
agent/1619-fix-grep-pipefail-crash)667a9a190415d58ff7ef78e0316cf10eb47f5262..HEAD)