feat(e2e): implement working admin e2e tests with Playwright - #158
Closed
ralphbean wants to merge 1 commit into
Closed
feat(e2e): implement working admin e2e tests with Playwright#158ralphbean wants to merge 1 commit into
ralphbean wants to merge 1 commit into
Conversation
ralphbean
marked this pull request as ready for review
April 3, 2026 13:19
ralphbean
force-pushed
the
agent-e2e-tests-working
branch
from
April 3, 2026 14:00
b0dd44a to
f5174de
Compare
Full lifecycle test: lock acquisition, teardown-first cleanup, app creation via Playwright browser automation, layer stack install/verify/analyze/uninstall/verify. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ralphbean
force-pushed
the
agent-e2e-tests-working
branch
2 times, most recently
from
April 3, 2026 14:28
d186438 to
fe5682c
Compare
This was referenced Apr 3, 2026
Member
Author
|
Closing in favor of #167 |
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
- Merges the design spec and implementation plan from PR #156Key Changes
E2E Test Infrastructure
E2E_GITHUB_PASSWORD_FILEsupport: Reads password from a file path whenE2E_GITHUB_PASSWORDenv var is not setworkflowPAT scope: Required for creating files in.github/workflows/directoriesCreateOrUpdateFileretries with exponential backoff for newly created repos (GitHub eventual consistency)Browser Automation
WaitUntilStateNetworkidlewithWaitUntilStateDomcontentloaded(GitHub keeps persistent connections)hook_attributesandredirect_urlto manifest JSON for GitHub's manifest flowLock and Cleanup
CreateOrUpdateFileinstead ofCreateFilefor lock (handles auto_init README)test-repoif it doesn't existTest Flow (all 6 phases pass)
Bug Fix
deletePAT(wrong number of return values)