docs(#1544): add ADR 0040 for /fs- slash command prefix - #1549
Conversation
Site previewPreview: https://f700f35e-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsLow
Info
Previous runReviewFindingsHigh
Previous runReviewFindingsHigh
Previous run (2)ReviewFindingsNo findings. |
Create ADR 0040 documenting the decision to namespace all fullsend slash commands with the /fs- prefix. This decision was previously captured only as a one-liner in the glossary, causing two separate issues (#1473, #1477) where agents proposed changes that contradicted the undocumented choice. The ADR records context (multiple AI tools claim bare slash command verbs), the decision (/fs- prefix for all commands), rejected alternatives (bare commands, /fullsend- prefix), and consequences. Also adds a note to ADR 0002 clarifying that its bare command examples (/triage, /implement, /review) are illustrative and superseded by the /fs- prefix convention. Note: make lint could not run (Go toolchain download permission denied in sandbox). This is a docs-only change with no Go code affected. Closes #1544 Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
7deae7f to
c66dd3a
Compare
| @@ -0,0 +1,78 @@ | |||
| --- | |||
There was a problem hiding this comment.
[high] correctness
ADR number collision. ADR 0040 already exists on main as docs/ADRs/0040-org-pool-for-parallel-e2e-tests.md (merged after this branch diverged). ADR 0041 also exists. This PR would create a second file numbered 0040, causing ambiguity in cross-references and the title line. The cross-reference from ADR 0002 (ADR 0040) would also be ambiguous.
Suggested fix: Renumber to the next available ADR number (0042). Update the filename, the title in frontmatter and heading, and the cross-reference in docs/ADRs/0002-initial-fullsend-design.md.
|
/fs-fix |
ADR 0040 (org-pool-for-parallel-e2e-tests) and ADR 0041 already exist on main. Renumber the /fs- prefix ADR to 0042 to avoid ambiguity. Updates the filename, title, heading, and cross-reference in ADR 0002. Addresses review feedback on #1549 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: fullsend-fix <fullsend-code@users.noreply.github.com>
🔧 Fix agent — iteration 1 (human-triggered)Addressed 1 review finding: renumbered ADR 0040 to 0042 to resolve collision with existing ADR 0040 (org-pool-for-parallel-e2e-tests) and ADR 0041 on main. Fixed (1):
Tests: passed Updated by fullsend fix agent |
Create ADR 0040 documenting the decision to namespace all fullsend slash commands with the /fs- prefix. This decision was previously captured only as a one-liner in the glossary, causing two separate issues (#1473, #1477) where agents proposed changes that contradicted the undocumented choice.
The ADR records context (multiple AI tools claim bare slash command verbs), the decision (/fs- prefix for all commands), rejected alternatives (bare commands, /fullsend- prefix), and consequences.
Also adds a note to ADR 0002 clarifying that its bare command examples (/triage, /implement, /review) are illustrative and superseded by the /fs- prefix convention.
Note: make lint could not run (Go toolchain download permission denied in sandbox). This is a docs-only change with no Go code affected.
Closes #1544
Post-script verification
agent/1544-adr-fs-prefix-convention)2ff84177096c79525e22b7738efa725a841f7cfe..HEAD)