feat(#1249): show version on banner line - #1493
Merged
Merged
Conversation
Add a version parameter to Printer.Banner() so the CLI version appears next to the brand name in terminal output. All call sites in admin.go and run.go now pass cli.Version(). This makes the version immediately visible in install logs and bug reports without requiring a separate --version call. Note: pre-commit could not run due to a sandbox Go toolchain permission issue (not related to this change). Unit tests and go vet passed. Closes #1249 Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
Site previewPreview: https://3c9855fb-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Clean, well-scoped change. All 7 |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
ralphbean
approved these changes
May 26, 2026
This was referenced May 26, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a version parameter to Printer.Banner() so the CLI version appears next to the brand name in terminal output. All call sites in admin.go and run.go now pass cli.Version(). This makes the version immediately visible in install logs and bug reports without requiring a separate --version call.
Note: pre-commit could not run due to a sandbox Go toolchain permission issue (not related to this change). Unit tests and go vet passed.
Closes #1249
Post-script verification
agent/1249-banner-version)addf9a24b1a9d937a2e2027b8c67a84f8d087739..HEAD)