Skip to content

fix: restore setup-agent-env.sh copy in prioritize scaffold workflow - #1457

Merged
ifireball merged 1 commit into
fullsend-ai:mainfrom
ifireball:fix/prioritize-setup-agent-env
May 28, 2026
Merged

fix: restore setup-agent-env.sh copy in prioritize scaffold workflow#1457
ifireball merged 1 commit into
fullsend-ai:mainfrom
ifireball:fix/prioritize-setup-agent-env

Conversation

@ifireball

Copy link
Copy Markdown
Member

Summary

  • Fixes Prioritize workflow template so workspace prep copies setup-agent-env.sh from internal/scaffold/fullsend-repo/.github/scripts/ (the script’s real location), not the non-existent repo-root .github/scripts/ path.
  • Aligns internal/scaffold/fullsend-repo/.github/workflows/prioritize.yml with gh-classify.yml, scribe.yml, and the reusable agent workflows: broad sparse-checkout of internal/scaffold/fullsend-repo/, SRC + LAYERED_DIRS pattern, and explicit cp "${SRC}/.github/scripts/setup-agent-env.sh".
  • Adds scaffold test assertions to prevent regressing to .defaults/.github/scripts.

Pairs with fullsend-ai/.fullsend#77 (runtime fix in the config repo). After both merge, orgs that sync from scaffold get the corrected template; .fullsend gets immediate relief without waiting for a v0 tag bump for the script itself (it already exists at the scaffold path on @v0).

Test plan

  • go test ./internal/scaffold/ -run TestPrioritizeWorkflowContent
  • After merge: scaffold sync / installer picks up updated prioritize.yml for new installs
  • With .fullsend#77 merged: re-run Prioritize workflow and confirm Setup agent environment succeeds

Made with Cursor

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

Site preview

Preview: https://f884a2cf-site.fullsend-ai.workers.dev

Commit: 3a8f8d8d36946ba9054476c1389ebd9901dac385

@ifireball ifireball self-assigned this May 26, 2026
Align prioritize.yml template with gh-classify and reusable workflows:
copy setup-agent-env.sh from internal/scaffold/fullsend-repo/.github/scripts/
instead of the non-existent repo-root .github/scripts path.

Pairs with fullsend-ai/.fullsend#77.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Barak Korren <bkorren@redhat.com>
@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

No findings.

The fix correctly addresses a broken path in the prioritize scaffold workflow. The old code tried to copy setup-agent-env.sh from .defaults/.github/scripts/ (a non-existent repo-root path), while the script actually lives at internal/scaffold/fullsend-repo/.github/scripts/setup-agent-env.sh. The new code uses ${SRC}/.github/scripts/setup-agent-env.sh where SRC=".defaults/internal/scaffold/fullsend-repo", matching the established pattern in all five reusable workflows (reusable-triage, reusable-review, reusable-code, reusable-retro, reusable-fix).

The sparse-checkout simplification from listing individual subdirectories to the broader internal/scaffold/fullsend-repo/ path is also consistent with those reusable workflows and ensures .github/scripts/ is included in the checkout.

The two new test assertions (assert.Contains for the correct cp command and assert.NotContains for the old broken path) provide good regression protection.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label May 26, 2026
@ifireball
ifireball added this pull request to the merge queue May 28, 2026
Merged via the queue into fullsend-ai:main with commit 37124df May 28, 2026
14 checks passed
@ifireball
ifireball deleted the fix/prioritize-setup-agent-env branch May 28, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants