fix(scaffold): add plugins/ to layered directories - #1252
Conversation
The scaffold step copies layered directories from upstream defaults into the runner workspace, but plugins/ was missing from the list. This caused harness validation to fail when code.yaml referenced plugins/gopls-lsp. Add plugins/ to LAYERED_DIRS in all five reusable workflows, the inline prioritize workflow (including its sparse-checkout), the Go layeredDirs slice, and the customized/ gitkeep set. Update tests accordingly. Closes #1251 Signed-off-by: Wayne Sun <gsun@redhat.com>
Site previewPreview: https://bd0a2d4b-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsMedium
Previous runReviewFindingsMedium
Low
Previous runReviewFindingsMedium
Low
Previous run (2)ReviewFindingsMedium
Low
Previous run (3)ReviewFindingsMedium
Low
|
Address review findings from review-squad: - Add plugins/ to PROTECTED_PATHS in post-fix.sh and REVIEW_PROTECTED_PATHS in post-review.sh to prevent autonomous agents from modifying/approving plugin config changes - Add customized/plugins/.gitkeep to e2e admin expected files - Update ADR 0035 to include plugins/ in all 4 directory enumerations and correct .gitkeep counts (7 → 8) - Reorder LAYERED_DIRS in 5 reusable workflows to match scaffold.go canonical order Signed-off-by: Wayne Sun <gsun@redhat.com>
…agram Address review-agent LOW findings: - Add plugins/ to protected paths list in pr-review SKILL.md (kept in sync with post-review.sh) - Add plugins/ to layered directories diagram in customizing-agents.md user guide Signed-off-by: Wayne Sun <gsun@redhat.com>
Signed-off-by: Wayne Sun <gsun@redhat.com>
Summary
pluginstoLAYERED_DIRSin all 5 reusable workflows (code, review, triage, fix, retro)pluginsto the inline prioritize workflow's sparse-checkout and both copy loops"plugins/"to the GolayeredDirsslice inscaffold.gocustomized/plugins/.gitkeepto match the pattern of other layered dirsTestLayeredDirsNotInstalled,TestCustomizedDirsInstalled,TestFullsendRepoFilesExist)Test plan
go test ./internal/scaffold/— all 34 tests passmake lint— passesplugins/gopls-lspis present in the workspace after scaffoldCloses #1251