Skip to content

docs(adr): synchronous workflow_call for event-driven agent dispatch - #1245

Merged
ifireball merged 1 commit into
fullsend-ai:mainfrom
ifireball:docs/adr-0039-synchronous-workflow-call
May 27, 2026
Merged

docs(adr): synchronous workflow_call for event-driven agent dispatch#1245
ifireball merged 1 commit into
fullsend-ai:mainfrom
ifireball:docs/adr-0039-synchronous-workflow-call

Conversation

@ifireball

@ifireball ifireball commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Propose ADR 0041: replace dispatch.yml → stage workflow_dispatch / gh workflow run with synchronous workflow_call so Actions runs stay linked for PR/issue debugging.
  • Drop dynamic agent discovery from ADR 0026 Option C for the event path instead of introducing sync tooling as compensation.
  • Note that discovery can be revisited after agent architecture work for ADR 0038.

Test plan

  • pre-commit run --files docs/ADRs/0041-synchronous-workflow-call-event-dispatch.md
  • ADR review only — no workflow or runtime changes in this PR

Made with Cursor

@github-actions

github-actions Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Site preview

Preview: https://17f5fae4-site.fullsend-ai.workers.dev

Commit: 5fa8757219cbf6529b2e6e14694c6fc4ffe0c51f

@ifireball ifireball self-assigned this May 20, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Review

Findings

No findings.

Previous run

Review

Findings

No findings.

Previous run (2)

Review

Findings

No findings.

Previous run (3)

Review

Findings

No findings.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label May 20, 2026
@ifireball
ifireball marked this pull request as ready for review May 20, 2026 10:26
@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels May 20, 2026
rh-hemartin
rh-hemartin approved these changes May 20, 2026
View reviewed changes

@rh-hemartin rh-hemartin left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

Did we take into account the billing for GH actions? There limits are very large in terms of minutes, but I don't know if this would be doubling minute usages for orgs using fullsend.

As a side note it is always funny how a lot of ADR frame options are very one sided.

@fullsend-ai-triage fullsend-ai-triage Bot mentioned this pull request May 20, 2026
Open
ggallen
ggallen reviewed May 20, 2026
View reviewed changes

@ggallen ggallen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverses the decision made in ADR-0026, taking away what I feel is essential functionality.

If this is done then replacing or adding new agents becomes much more complicated.

@ifireball

ifireball commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@rh-hemartin

I agree.

Did we take into account the billing for GH actions? There limits are very large in terms of minutes, but I don't know if this would be doubling minute usages for orgs using fullsend.

As a side note it is always funny how a lot of ADR frame options are very one sided.

Not quite sure why are you claiming this particular ADR would contribute towards more usage minutes, it could end up being cheaper if e.g. workflow_call is cheaper then workflow_dispatch.

@ifireball

ifireball commented May 25, 2026

Copy link
Copy Markdown
Member Author

@ggallen

This reverses the decision made in ADR-0026, taking away what I feel is essential functionality.

If this is done then replacing or adding new agents becomes much more complicated.

Yes, I'm being explicit about that, trying to find a middle ground where we would add build time tooling and CI to do "agent discovery" instead a fully dynamic discovery which requires async dispatch.

@rh-hemartin

rh-hemartin commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Not quite sure why are you claiming this particular ADR would contribute towards more usage minutes, it could end up being cheaper if e.g. workflow_call is cheaper then workflow_dispatch.

Then I'm understanding the feature wrong. However not sure if it is even relevant. Nevermind then

@ifireball
ifireball force-pushed the docs/adr-0039-synchronous-workflow-call branch from ae37296 to 6fefc29 Compare May 27, 2026 06:05
@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels May 27, 2026
@ifireball
docs(adr): propose ADR 0041 synchronous workflow_call dispatch
5fa8757 
Replace dispatch.yml gh workflow run fan-out with workflow_call for UI
traceability, and drop ADR 26 dynamic agent discovery without adding a
compile-time sync substitute. Discovery may be revisited after ADR 38.

Signed-off-by: Barak Korren <bkorren@redhat.com>
@ifireball
ifireball force-pushed the docs/adr-0039-synchronous-workflow-call branch from 6fefc29 to 5fa8757 Compare May 27, 2026 06:10
@ifireball
ifireball added this pull request to the merge queue May 27, 2026
@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels May 27, 2026
Merged via the queue into fullsend-ai:main with commit dbd72e2 May 27, 2026
9 checks passed
@ifireball
ifireball deleted the docs/adr-0039-synchronous-workflow-call branch May 27, 2026 06:18
This was referenced May 27, 2026
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggallen ggallen ggallen left review comments
@rh-hemartin rh-hemartin rh-hemartin approved these changes
+1 more reviewer
@fullsend-ai-review fullsend-ai-review[bot] fullsend-ai-review[bot] approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ifireball ifireball

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ifireball @rh-hemartin @ggallen