Skip to content

build(sandbox): add jq to base image - #1151

Merged
rh-hemartin merged 1 commit into
mainfrom
feat/add-jq-to-sandbox-image
May 19, 2026
Merged

build(sandbox): add jq to base image#1151
rh-hemartin merged 1 commit into
mainfrom
feat/add-jq-to-sandbox-image

Conversation

@rh-hemartin

Copy link
Copy Markdown
Member

Summary

  • Adds jq to the base sandbox image alongside rsync in the existing apt-get block
  • Without jq, agents fall back to python3 -c "import json,sys; ..." one-liners, wasting ~500–1000 tokens and 5–10 seconds per recovery sequence

Test plan

  • Sandbox image builds successfully (CI)
  • which jq succeeds inside the sandbox at runtime
  • Review agent run shows no jq-related error recovery in transcript

Closes #1126

Agents fall back to verbose python3 one-liners when jq is absent,
wasting ~500-1000 tokens per recovery sequence.

Closes #1126
@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://18a2064a-site.fullsend-ai.workers.dev

Commit: d34529150235936ab7a04bc46a64bd88549494e9

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [documentation-currency] images/README.md:17 — The sandbox image description lists installed tools (Claude Code, rsync, gitleaks, tirith, pre-commit, gitlint, ProtectAI model) but does not include jq. After this PR merges, the README will be incomplete.
    Remediation: Add jq to the tool list on line 17 of images/README.md to match the updated Containerfile.

@fullsend-ai-review

Copy link
Copy Markdown

Review follow-ups

Created follow-up issues for actionable non-blocking review findings:

  • #1153 — The sandbox image description lists installed tools (Claude Code, rsync, gitleaks, tirith, pre-commit, gitlint, ProtectAI model) but does not include jq. After this PR merges, the README will be incomplete.

@rh-hemartin
rh-hemartin added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 5f4e79e May 19, 2026
11 checks passed
@rh-hemartin
rh-hemartin deleted the feat/add-jq-to-sandbox-image branch May 19, 2026 10:24
ifireball pushed a commit to ifireball/fullsend that referenced this pull request May 25, 2026
PR fullsend-ai#1151 added jq to the sandbox base image but did not update the
tool list in images/README.md. Add jq alongside the existing entries
so the documentation matches the installed packages.

Closes fullsend-ai#1196
Closes fullsend-ai#1153

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add jq to the review agent sandbox environment

2 participants