fix: detect public apps without --public flag and filter shared slugs by app-set - #1128
Merged
Conversation
…nd detect public apps without --public - Apply filterSlugsByAppSet to shared slugs so cross-app-set installs don't shadow each other (e.g. nonflux-triage no longer blocks fullsend-ai-triage). - After recoverCreatedApp + ensureInstalled, resolve AppID from the installation so ROLE_APP_IDS is updated correctly. - Always check GetAppClientID before the manifest flow regardless of --public flag. When a public app exists and --public was not passed, prompt the user to confirm installation instead of silently falling through to create a duplicate via the manifest flow. Signed-off-by: Wayne Sun <gsun@redhat.com>
Site previewPreview: https://d846cb82-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Address review findings: - Propagate findExistingInstallation errors in recover path instead of silently swallowing them, matching the public-app path's behavior. - Replace misleading "public app" terminology with "existing app" in prompts shown when --public is not set. - Use StepInfo instead of StepDone before user confirmation to avoid showing a success checkmark before the user has decided. - Add tests: recoverCreatedApp AppID resolution through Run(), prompter error propagation, and --public flag skips prompt assertion. Signed-off-by: Wayne Sun <gsun@redhat.com>
fullsend-ai-review
Bot
added
ready-for-merge
This was referenced Jul 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetAppClientIDbefore the manifest flow regardless of--publicflag. When a public app exists and--publicwas not passed, prompt the user to confirm installation instead of silently falling through to create a duplicate via the manifest flow.filterSlugsByAppSetto shared slugs fromcopySharedAppPEMsso cross-app-set installs don't shadow each other (e.g.nonflux-triageno longer blocksfullsend-ai-triage).recoverCreatedApp+ensureInstalled, resolve AppID from the installation soROLE_APP_IDSis updated correctly.Test plan
--publicflag (auto-install, no prompt)--publicflag (user confirms → installs)--publicflag (user declines → error with guidance)filterSlugsByAppSeton shared slugsgo vetcleanfullsend admin install-repowith--app-set fullsend-aiwithout--publicagainst an org with existing public apps