feat: add URL detection and integrity hash parsing to harness package - #1095
Merged
Conversation
Site previewPreview: https://9c414d60-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReviewFindingsNo findings. Clean utility addition — URL validation has appropriate defense-in-depth (HTTPS-only, userinfo rejection, belt-and-suspenders Previous run (2)ReviewFindingsNo findings. Previous run (3)ReviewFindingsLow
Info
|
Review follow-upsCreated follow-up issues for actionable non-blocking review findings:
|
rh-hemartin
approved these changes
May 19, 2026
ggallen
force-pushed
the
feat/url-detection-integrity-hash
branch
from
May 26, 2026 15:22
4cae82d to
b44cfad
Compare
Add utility functions for detecting URLs, absolute/relative paths, and parsing SHA256 integrity hashes from URL fragments. Includes comprehensive tests covering HTTPS validation, scheme rejection, hash extraction, and edge cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
ggallen
force-pushed
the
feat/url-detection-integrity-hash
branch
from
May 26, 2026 15:42
b44cfad to
2428288
Compare
This was referenced May 26, 2026
4 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsURL,IsAbsPath,IsRelPathhelpers for classifying resource referencesParseIntegrityHashfor extracting and validating#sha256=...fragments from URLsTest plan
go test ./internal/harness/...passesmake lintpasses🤖 Generated with Claude Code