chore: update fullsend shim workflow

[fullsend-ai-fullsend]

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

[github-actions]

Site preview

Preview: https://58740a92-site.fullsend-ai.workers.dev

Commit: 7fa0a5b7bd196b099cde3463f9433cefcf1e0d08

[fullsend-ai-review]

Review

Findings

High

• [protected-path] .github/workflows/fullsend.yaml — This file is under the .github/ protected path. The PR has no linked issue and the description does not explain why this governance file is being modified beyond stating it syncs with the template. Human approval is required for all protected-path changes regardless of context.
  Remediation: Link a tracking issue that authorizes this shim update, or have a human reviewer approve directly.

Low

• [intent-alignment] .github/workflows/fullsend.yaml:47 — The PR description claims to sync the shim with the current template in .fullsend, but the shim-workflow-call.yaml template at HEAD does not include secrets: {}. The change is valid security hardening (preventing automatic secret inheritance), but the stated justification of "template sync" does not match the template's current state.
  Remediation: Update the PR description to accurately describe this as a security hardening change, or update the template to include secrets: {} if that is the intended canonical form.

Info

• [platform-security] .github/workflows/fullsend.yaml:47 — Adding secrets: {} explicitly prevents automatic secret inheritance from the calling workflow to the reusable dispatch.yml. This aligns with the shim's design (agents fetch scoped tokens from the centralized mint via OIDC, no repo secrets needed) and ADR-0031's guidance against secrets: inherit. Positive security hardening.

Previous run

Review

Findings

High

• [protected-path] .github/workflows/fullsend.yaml — This file is under the .github/ protected path. The PR has no linked issue and the description does not explain why this governance file is being modified beyond "syncing with the template." Human approval is required for all protected-path changes regardless of context.
  Remediation: Link a tracking issue that authorizes this shim update, or have a human reviewer approve directly.

Low

• [correctness] .github/workflows/fullsend.yaml:47 — Adding secrets: {} explicitly passes no secrets to the external dispatch.yml workflow. The reusable-dispatch.yml in this repo declares FULLSEND_GCP_PROJECT_ID as a required secret (line 42). The shim calls a different workflow (fullsend-ai/.fullsend/.github/workflows/dispatch.yml@main), so this may not apply, but verify the external dispatch workflow does not require caller-provided secrets.
  Remediation: Confirm the external .fullsend/dispatch.yml has no required secrets, or that it sources them from its own repo context.

Info

• [platform-security] .github/workflows/fullsend.yaml:47 — Adding secrets: {} is a positive security hardening. It explicitly prevents automatic secret inheritance from the calling workflow, aligning with the file header comment that agents use OIDC tokens from the centralized mint rather than repo secrets.

[fullsend-ai-review]

See the review comment for full details.

[fullsend-ai-review]

[low] correctness

Adding secrets: {} explicitly passes no secrets to the external dispatch.yml. The reusable-dispatch.yml in this repo declares FULLSEND_GCP_PROJECT_ID as a required secret. Verify the external .fullsend/dispatch.yml does not require caller-provided secrets.

Suggested fix: Confirm the external dispatch.yml sources secrets from its own repo context.

[fullsend-ai-review]

[info] platform-security

Adding secrets: {} is positive security hardening — explicitly prevents automatic secret inheritance, aligning with the OIDC token mint architecture.

[waynesun09]

The lint fix:
#1074

[fullsend-ai-review]

See the review comment for full details.

[fullsend-ai-review]

[low] intent-alignment

The PR description claims to sync the shim with the current template, but the shim-workflow-call.yaml template at HEAD does not include secrets: {}. The change is valid security hardening, but the stated justification does not match the template's current state.

Suggested fix: Update the PR description to accurately describe this as a security hardening change, or update the template to include secrets: {} if that is the intended canonical form.

[fullsend-ai-review]

[info] platform-security

Adding secrets: {} explicitly prevents automatic secret inheritance from the calling workflow to the reusable dispatch.yml. This aligns with the shim design (agents fetch scoped tokens from the centralized mint via OIDC) and ADR-0031 guidance against secrets: inherit. Positive security hardening.

[rh-hemartin]

/fs-fix rebase this

[rh-hemartin]

/fs-fix rebase this