fix(#997): use actions_variables instead of variables for GitHub API permission key - #1004
Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
Closed
fix(#997): use actions_variables instead of variables for GitHub API permission key#1004fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…permission key
The AppPermissions JSON tag and the mint's rolePermissions map both
used "variables" as the permission key. GitHub's API expects
"actions_variables" for the Actions variables permission. This
mismatch caused two problems:
1. The installer's permission check reported the app was missing
variables:read even when actions_variables:read was configured.
2. The mint requested "variables": "read" when creating installation
tokens, which GitHub silently ignored, resulting in 403 errors
when accessing /repos/{owner}/{repo}/actions/variables/{name}.
Changed the JSON tag in AppPermissions from "variables" to
"actions_variables" and updated the fullsend role in
rolePermissions to use "actions_variables" as the map key.
Added tests verifying both the JSON serialization key and the
role permission key.
Note: pre-commit could not run (network error, exit 3).
Manual pre-commit verification required.
Closes #997
|
fullsend review is working on this — view logs |
Member
|
Duplicate of #998 |
This was referenced May 15, 2026
Closed
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppPermissions JSON tag and the mint's rolePermissions map both used "variables" as the permission key. GitHub's API expects "actions_variables" for the Actions variables permission. This mismatch caused two problems:
variables:read even when actions_variables:read was configured.
tokens, which GitHub silently ignored, resulting in 403 errors
when accessing /repos/{owner}/{repo}/actions/variables/{name}.
Changed the JSON tag in AppPermissions from "variables" to "actions_variables" and updated the fullsend role in rolePermissions to use "actions_variables" as the map key. Added tests verifying both the JSON serialization key and the role permission key.
Note: pre-commit could not run (network error, exit 3). Manual pre-commit verification required.
Closes #997
Post-script verification
agent/997-fix-actions-variables-key)56dbc6e992087805c0a4a24c9df39dfefc056a6f..HEAD)