Skip to content

fix: remove pull_request_review from dispatch-review condition - #6

Merged
ascerra merged 1 commit into
mainfrom
fix/review-bot-feedback-loop
Apr 23, 2026
Merged

fix: remove pull_request_review from dispatch-review condition#6
ascerra merged 1 commit into
mainfrom
fix/review-bot-feedback-loop

Conversation

@ralphbean

Copy link
Copy Markdown
Member

Summary

  • Removes pull_request_review from the dispatch-review job's if condition
  • Keeps the pull_request_review on: trigger for a future fix agent

Problem

Review bot feedback loop: each bot review triggers another dispatch-review, causing infinite re-reviews on the same SHA. See fullsend-ai/fullsend#379.

🤖 Generated with Claude Code

Prevents review bot feedback loop where each bot review triggers another
dispatch-review, causing infinite re-reviews on the same SHA.
@ralphbean
ralphbean requested a review from a team as a code owner April 23, 2026 18:46

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: #6

Head SHA: f83d8ef
Timestamp: 2026-04-23T00:00:00Z
Outcome: approve

Summary

This is a correct, minimal fix for a review-bot feedback loop. The change removes github.event_name == 'pull_request_review' from the dispatch-review job's if condition, which prevents the bot's own review submissions from re-triggering the dispatch-review pipeline. The pull_request_review trigger is intentionally retained in the top-level on: block for future use by a planned fix agent. The YAML syntax, multi-line expression structure, and remaining conditions are all correct after the deletion.

Findings

Critical

None.

High

None.

Medium

None.

Low

None.

Info

  • [style/conventions] .github/workflows/fullsend.yaml — The pull_request_review event remains in the on: trigger block (line 21-22) but no job currently matches on it. This means GitHub will fire the workflow on review submissions and all jobs will be skipped. This is intentional per the PR description (reserved for a future fix agent), but worth tracking — if the fix agent is not added, consider removing the unused trigger to avoid unnecessary workflow runs.

Footer

Outcome: approve
This review applies to SHA f83d8efd775980ca9099c7d545d617649f37390c. Any push to the PR head clears this review and requires a new evaluation.

@ascerra
ascerra added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 91414e5 Apr 23, 2026
9 checks passed
@ascerra
ascerra deleted the fix/review-bot-feedback-loop branch April 23, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants