Skip to content

fix(#914): add Skill to triage and prioritize tools - #917

Merged
ascerra merged 1 commit into
mainfrom
agent/914-restore-skill-tool
Aug 21, 2026
Merged

fix(#914): add Skill to triage and prioritize tools#917
ascerra merged 1 commit into
mainfrom
agent/914-restore-skill-tool

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Since Claude Code v2.1.119 (enforced on 2026-07-06), frontmatter tools: is a hard clamp on agent init tools. The triage and prioritize agents list skills in their skills: field (issue-labels and customer-research respectively), but their tools: field was Bash-only — the Skill tool was absent at runtime, making the declared skills silently inert.

This PR adds Skill to the tools: frontmatter in both agents/triage.md and agents/prioritize.md, restoring skill activation alongside the existing Bash scoping.

Not modified: agents/scribe.md — it has skills: [] (no skills to load) and is explicitly out of scope.

Changes

  • agents/triage.md: tools: Bash(gh,curl,jq)tools: Bash(gh,curl,jq),Skill
  • agents/prioritize.md: tools: Bash(gh,curl,jq)tools: Bash(gh,curl,jq),Skill

Testing

  • Secret scan: passed
  • make test: all tests pass (pre-existing failures in post-retro-test.sh are unrelated to this change)
  • Pre-commit: could not run due to sandbox network restriction (exit 3); post-script runs it authoritatively

Closes #914

Post-script verification

  • Branch is not main/master (agent/914-restore-skill-tool)
  • Secret scan passed (gitleaks — 7ad7b5000373150ce1bf1a312dd6713045bea8f8..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

Since Claude Code v2.1.119 (enforced 2026-07-06), frontmatter
tools: is a hard clamp on agent init tools. The triage and
prioritize agents list skills (issue-labels and
customer-research respectively) but their tools: field was
Bash-only, so the Skill tool was absent at runtime. Skills
declared in skills: were silently inert.

Add Skill to the tools: field in both agents/triage.md and
agents/prioritize.md, restoring the Skill tool alongside the
existing Bash scoping. Scribe is not modified (skills: [] —
no skills to load).

Note: pre-commit could not run (sandbox network restriction,
exit 3). Post-script runs pre-commit authoritatively on the
runner.

Closes #914
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 21, 2026 11:26
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Aug 21, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 21, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:28 AM UTC · Completed 11:40 AM UTC

Commit: ab2d45d · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] agents/triage.md, agents/prioritize.md — Both changed files are under the agents/ protected path. The PR is linked to issue Triage and prioritize cannot open listed skills (Skill tool missing from tools:) #914 and the rationale is well-documented (restoring Skill tool access for agents that declare skills in their frontmatter). Human approval is always required for changes to protected paths, regardless of context.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 21, 2026

@ben-alkov ben-alkov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascerra
ascerra added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit 12f5d88 Aug 21, 2026
74 of 81 checks passed
@ascerra
ascerra deleted the agent/914-restore-skill-tool branch August 21, 2026 18:56
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 21, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 6:58 PM UTC · Completed 7:10 PM UTC

Commit: ab2d45d · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #917 — Add Skill to triage and prioritize tools

Timeline

  • 11:12ZIssue #914 opened with detailed evidence that triage and prioritize agents had silently lost Skill tool access for 6 weeks (since 2026-07-06)
  • 11:13Z — Both code and triage agents triggered simultaneously (ready-to-code and ready-for-triage labels both present at issue creation)
  • 11:19Z — First code run cancelled after 6 minutes when triage re-applied ready-to-code, spawning a second code dispatch that superseded it via concurrency group
  • 11:20–11:26Z — Second code run succeeded in 3m35s ($2.01), creating PR fix(#914): add Skill to triage and prioritize tools #917 with the correct 2-line fix
  • 11:28–11:40ZReview agent ran ($2.63), found 1 medium protected-path finding, applied requires-manual-review
  • 18:23Z — ben-alkov approved; 18:43Z — ascerra approved; 18:56Z — merged

What went well

  • Zero rework. Code agent produced the correct fix on the first attempt — added ,Skill to tools: in both agents/triage.md and agents/prioritize.md, correctly excluded scribe.md.
  • Efficient execution. 44 turns, $2.01, 3m35s for a surgical 2-line change.
  • Review quality. The review agent correctly identified the protected-path concern and found no functional bugs, matching the human reviewers' assessment.
  • Excellent issue quality. Issue Triage and prioritize cannot open listed skills (Skill tool missing from tools:) #914 provided 22/22 affected runs as evidence, contrast with pre-breakage runs, and full root cause analysis, giving the code agent unambiguous context.

Evidence for existing issues

  • fullsend#945 (tool-skill consistency lint): This bug persisted for 6 weeks because no automated check validates that agents declaring skills: also include Skill in tools:. A platform-level lint would catch this class of regression at commit time.
  • agents#256 / agents#379 (model specifier in sub-agents): During review, two sonnet sub-agents failed because claude-sonnet-4-5@20250929 was unavailable, requiring re-dispatch without model override. Added latency but did not affect review quality.
  • fullsend#766 (dispatch dedup): The first code run was cancelled after 6 minutes when triage re-applied ready-to-code, wasting compute. The race between simultaneous ready-for-triage and ready-to-code labels is a concrete instance of the dispatch dedup gap.

Proposals filed

jflowers pushed a commit to jflowers/fullsend-ai-fullsend that referenced this pull request Aug 24, 2026
After fullsend-ai/agents#917 merged (Aug 21 18:56 UTC), the
issue-labels skill became active for the triage agent — the
Skill tool was added to the agent's tools: frontmatter, which
restored a skill that was previously silently inert. The
additional skill invocation adds conversational turns, pushing
at least one eval case past the max_turns: 30 budget and
causing the max_turns judge to score 75% (3/4) against its
100% threshold.

Raise max_turns from 30 to 35 for all four triage eval cases
to accommodate the now-active issue-labels skill. All cases
are affected by the skill activation since labeling is part
of every triage run. A uniform 5-turn increase is consistent
with the eval docs guidance ("start generous and tighten")
and provides headroom without masking real regressions.

Note: pre-commit could not run (sandbox network blocks hook
install). lint-eval-cases passed.

Closes fullsend-ai#6475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test ready-for-review Triggers review agent dispatch requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triage and prioritize cannot open listed skills (Skill tool missing from tools:)

2 participants