sync: port triage agent changes from scaffold - #8
Conversation
… action Replace the `blocked` action (single `blocked_by` URL) with `prerequisites` (structured `existing` and `create` arrays for multiple prerequisite tracking and cross-repo issue creation). Add `question` action for support questions that should be answered directly rather than triaged as bugs. Ported from fullsend-ai/fullsend commits: - e492ac78 feat(schema): replace blocked with prerequisites action (#401) - 1e725001 feat(#1811): add question action to triage agent Signed-off-by: Greg Allen <greg@fullsend.ai> Signed-off-by: Greg Allen <gallen@redhat.com>
…isting-PR gate - Replace blocked references with prerequisites action throughout - Add existing-PR gate (hard constraint): if an open PR already addresses the issue, use prerequisites instead of sufficient - Add question action handling for support questions - Update section 2c to use prerequisite terminology - Scope anti-premature-resolution rule to user-facing questions only Ported from fullsend-ai/fullsend commits: - b2055cb1 feat(triage): replace blocked with prerequisites in agent prompt - 6f79d87a fix(triage): correct label name in agent prompt - 1e725001 feat(#1811): add question action - 2933555f fix(#2024): agent must not ask reporters implementation questions - 8c7bec88 fix(#2237): scope anti-premature-resolution rule - 095039eb fix(#1321): add existing-PR gate - e57f10a7 fix(triage): address review feedback on prerequisites action Signed-off-by: Greg Allen <greg@fullsend.ai> Signed-off-by: Greg Allen <gallen@redhat.com>
…tics - Add prerequisites case with cross-repo issue creation, allowlist validation, and blocked label management - Add question action case - Redirect error messages to stderr for all failure paths - Add diagnostic output (stderr) to help debug post-script failures - Defer ready-to-code label until after label_actions to avoid webhook race conditions - Guard GITHUB_WORKSPACE for local execution Ported from fullsend-ai/fullsend commits: - 0fb3793c fix(#1752): defer ready-to-code label until after label_actions - 3a44b0cc feat(triage): handle prerequisites action in post-script - 12b47a9a fix(#2393): add diagnostic stderr output to post-script failure paths - 51ec19e2 fix(#2458): guard GITHUB_WORKSPACE in post-triage.sh for local execution Signed-off-by: Greg Allen <greg@fullsend.ai> Signed-off-by: Greg Allen <gallen@redhat.com>
Include the `question` label in the set of triage labels that are reset before a new triage run. Ported from fullsend-ai/fullsend commit 1a2db28a. Signed-off-by: Greg Allen <greg@fullsend.ai> Signed-off-by: Greg Allen <gallen@redhat.com>
Update post-triage-test.sh: - Add gh mock for label list API and issue creation - Add GITHUB_WORKSPACE setup with config.yaml allowlist fixture - Replace blocked tests with prerequisites tests (existing and create) - Add tests for allowed/disallowed issue creation targets - Add question action tests Update validate-output-schema-test.sh: - Replace blocked validation tests with prerequisites tests - Add question action validation test - Add prerequisites-both-arrays-empty negative test Ported from fullsend-ai/fullsend commits: - 080368cf fix(triage): update post-triage tests for prerequisites action - 11bae491 fix(triage): update schema validation tests for prerequisites action Signed-off-by: Greg Allen <greg@fullsend.ai> Signed-off-by: Greg Allen <gallen@redhat.com>
Broaden the issue-labels skill to work with both issues and pull requests. Remove the hardcoded control-label blocklist in favor of pipeline-side filtering. Simplify the constraint language to be agent-agnostic. Ported from fullsend-ai/fullsend commit 3ed6080c. Signed-off-by: Greg Allen <greg@fullsend.ai> Signed-off-by: Greg Allen <gallen@redhat.com>
Migrate from deprecated `runner_env` to the nested `env.runner` / `env.sandbox` format per ADR 0055. Add top-level pre_script/post_script alongside forge-specific ones. Add sandbox env block for GitHub forge to forward GITHUB_ISSUE_URL and GH_TOKEN into the sandbox. Ported from fullsend-ai/fullsend commit 3ce10f4d. Signed-off-by: Greg Allen <greg@fullsend.ai> Signed-off-by: Greg Allen <gallen@redhat.com>
|
Closing — took the wrong approach by overwriting agents repo files with scaffold versions. The agents repo files are already up to date; the scaffold is the one that needs to catch up or be deprecated. |
|
🤖 Finished Review · ✅ Success · Started 2:44 PM UTC · Completed 2:51 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 2:49 PM UTC · Completed 2:56 PM UTC |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
Retro: PR #8 — sync: port triage agent changes from scaffoldTimeline
AnalysisReview timing: The review agent did substantial work (31 tool calls, 4 sub-agents, ~7 minutes of agent time) but its output was never posted because the PR merged before the review completed. This is a known class of issue. No review before merge: The PR was merged without any formal review — no human approval, no bot review. For a manual sync PR of this size, this is a process choice by the maintainer. Retro debounce worked correctly: The first retro dispatch (on PR reopen) was properly debounced/cancelled, and only the post-merge retro ran. Existing coverageAll identified improvement areas are already tracked by open issues in
No new proposals are warranted — existing issues comprehensively cover the improvement opportunities observed in this workflow. |
Summary
Sync triage agent files with
fullsend-ai/fullsendscaffold, bringing the agents repo up to date with 17 commits that landed in the scaffold since the initial fork.Changes by commit:
blockedaction (singleblocked_byURL) withprerequisites(structuredexisting/createarrays); addquestionactionquestionlabel to triage label reset setrunner_env→env.runner/env.sandboxper ADR 0055Original commits ported:
0fb3793cfix(#1752): defer ready-to-code label until after label_actions1e725001feat(#1811): add question action to triage agent1a2db28afix: update stale doc references for question control labele492ac78feat(schema): replace blocked with prerequisites actionb2055cb1feat(triage): replace blocked action with prerequisites in agent prompt6f79d87afix(triage): correct label name in agent prompt3a44b0ccfeat(triage): handle prerequisites action in post-script080368cffix(triage): update post-triage tests for prerequisites action11bae491fix(triage): update schema validation tests for prerequisites action2933555ffix(#2024): triage agent must not ask reporters implementation questions8c7bec88fix(#2237): scope anti-premature-resolution rule to user-facing questionse57f10a7fix(triage): address review feedback on prerequisites action12b47a9afix(#2393): add diagnostic stderr output to post-script failure paths095039ebfix(#1321): add existing-PR gate to triage agent definition3ed6080cfeat(skill): generalize issue-labels for issues and PRs51ec19e2fix(#2458): guard GITHUB_WORKSPACE in post-triage.sh for local execution3ce10f4drefactor(harness): migrate triage to env.runner/env.sandbox (ADR 0055)Test plan
post-triage-test.sh— all 46 tests passvalidate-output-schema-test.sh— all triage-specific tests pass (non-triage schema tests expected to fail since fix/review schemas not in this repo)