Skip to content

fix(#537): add remediation consistency rule to correctness sub-agent #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fullsend-ai-coder wants to merge 1 commit into from
+12 −0
Closed

fix(#537): add remediation consistency rule to correctness sub-agent #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions skills/pr-review/sub-agents/correctness.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,18 @@ or inter-component contract in the diff:
unavailable, does the caller handle it or silently proceed as if it
succeeded?

**Remediation consistency:** Before suggesting a remediation, verify it
is not contradicted by your own finding analysis. Specifically:

- If your severity rationale states that a prior state is "already
broken" or "no longer functional," do not suggest reverting to or
falling back to that broken state as remediation.
- If the PR description or linked issue explains that a companion
change in another repo provides the missing piece, and you have
acknowledged this context, frame the remediation around merge
coordination (e.g., "ensure companion PR lands") rather than
suggesting a fallback to the broken prior approach.

**Consumer completeness:** If the diff adds new values to an enum,
dispatch table, JSON schema enum, or case/switch structure, identify all
code paths that consume or branch on that type (including scripts,
Expand Down
Loading