fix(test): add mock yq to prerequisites test setup (#47) - #50
fix(test): add mock yq to prerequisites test setup (#47)#50fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The prerequisites-creates-allowed-issue test case fails when yq is not installed because post-triage.sh disables cross-repo issue creation when it cannot parse config.yaml. Add a mock yq binary to MOCK_BIN that reads the YAML fixture and returns allowlist values, following the existing pattern for mock gh and fullsend binaries. This makes the test hermetic — it passes regardless of whether yq is installed on the host. Closes #47
e84d18b to
2f09703
Compare
Functional tests did not runFunctional tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the |
|
🤖 Finished Retro · ✅ Success · Started 9:20 PM UTC · Completed 9:30 PM UTC |
Retro: PR #50 — mock yq approach rejected in favor of simpler env fixTimeline
AnalysisThe retro agent's proposal was the root cause of the rejection. It framed the problem as "test lacks a mock dependency" and recommended a code-level mock, when the simplest fix was an environment change (install Evidence for existing issues
Proposals filed |
The prerequisites-creates-allowed-issue test case fails when yq is not installed because post-triage.sh disables cross-repo issue creation when it cannot parse config.yaml. Add a mock yq binary to MOCK_BIN that reads the YAML fixture and returns allowlist values, following the existing pattern for mock gh and fullsend binaries. This makes the test hermetic — it passes regardless of whether yq is installed on the host.
Closes #47
Post-script verification
agent/47-mock-yq-prerequisite-test)2540ede96537b32447321564bec60226efca120e..HEAD)