Skip to content

fix(test): add mock yq to prerequisites test setup (#47) - #50

Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/47-mock-yq-prerequisite-test
Closed

fix(test): add mock yq to prerequisites test setup (#47)#50
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/47-mock-yq-prerequisite-test

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The prerequisites-creates-allowed-issue test case fails when yq is not installed because post-triage.sh disables cross-repo issue creation when it cannot parse config.yaml. Add a mock yq binary to MOCK_BIN that reads the YAML fixture and returns allowlist values, following the existing pattern for mock gh and fullsend binaries. This makes the test hermetic — it passes regardless of whether yq is installed on the host.


Closes #47

Post-script verification

  • Branch is not main/master (agent/47-mock-yq-prerequisite-test)
  • Secret scan passed (gitleaks — 2540ede96537b32447321564bec60226efca120e..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner July 7, 2026 22:57
The prerequisites-creates-allowed-issue test case fails when yq
is not installed because post-triage.sh disables cross-repo issue
creation when it cannot parse config.yaml. Add a mock yq binary
to MOCK_BIN that reads the YAML fixture and returns allowlist
values, following the existing pattern for mock gh and fullsend
binaries. This makes the test hermetic — it passes regardless of
whether yq is installed on the host.

Closes #47
@ralphbean
ralphbean force-pushed the agent/47-mock-yq-prerequisite-test branch from e84d18b to 2f09703 Compare July 8, 2026 21:18
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Functional tests did not run

Functional tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

@ralphbean ralphbean closed this Jul 8, 2026
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 8, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 9:20 PM UTC · Completed 9:30 PM UTC
Commit: 2f09703 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #50 — mock yq approach rejected in favor of simpler env fix

Timeline

  1. 2026-07-07 22:42 UTC — Retro bot creates issue #47 from PR fix(triage): enforce question action and label consistency #40 analysis, identifying prerequisites-creates-allowed-issue test failure when yq is missing. Recommends mock yq binary (preferred) or skip test.
  2. 2026-07-07 22:46 UTC — Triage agent completes, echoes mock approach, adds ready-to-code.
  3. 2026-07-07 22:57 UTC — Code agent creates PR #50 with 46-line bash mock yq parser (~10 min implementation).
  4. No review agent ran — PR had zero automated reviews over 22 hours.
  5. 2026-07-08 21:19 UTC — Human (ralphbean) closes PR without merge, commenting: prefers simply ensuring yq is present in the test environment rather than mocking it.

Analysis

The retro agent's proposal was the root cause of the rejection. It framed the problem as "test lacks a mock dependency" and recommended a code-level mock, when the simplest fix was an environment change (install yq). The code agent faithfully implemented the retro's preferred approach, producing a 46-line bash YAML parser. The human wanted a ~1-line change. This is a different failure mode from approach preference order (covered by fullsend-ai/fullsend#1471) — here the issue body didn't include the simpler option at all.

Evidence for existing issues

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(test): guard prerequisites test for missing yq dependency

1 participant