feat(#428): instruct triage agent to omit redundant commentary - #429
Conversation
Add an anti-redundancy rule to the triage agent's comment content rules. The triage agent now must check whether the issue body or prior comments already convey a point before including it in the triage comment. When the issue is self-evident, the agent should skip restating problem, root cause, and other dimensions, and focus the comment on net-new value: related issues, proposed test cases, blocking dependencies, severity assessment, or information gaps. Also update the sufficient action's comment field description to reinforce the same principle. Note: pre-commit could not run in the sandbox (network error, exit code 3). The post-script runs an authoritative pre-commit check on the runner. One pre-existing test failure (prerequisites-creates-allowed-issue) is unrelated to this change and reproduces identically on the base branch. Closes #428
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 7:48 AM UTC · Completed 8:02 AM UTC |
ReviewFindingsMedium
Previous runReviewFindingsMedium
Low
Labels: PR modifies agents/triage.md, the triage agent definition file |
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 8:11 AM UTC · Completed 8:16 AM UTC |
Add parenthetical note distinguishing comment content conciseness from structured-field completeness. The triage_summary object fields must always be fully populated regardless of issue clarity. Addresses review feedback on #429
🔧 Fix agent — iteration 1 (human-triggered)Addressed the instruction-completeness finding by adding a parenthetical note clarifying that the anti-redundancy rule applies only to the comment field, not to the triage_summary structured object. The protected-path finding is informational and requires human approval for merge. Fixed (1):
Disagreed (1):
Tests: passed Updated by fullsend fix agent |
|
/fs-fix add an eval case to test this behavior |
|
🤖 Finished Fix · ✅ Success · Started 8:19 AM UTC · Completed 8:26 AM UTC |
Add case 007-self-evident-bug-redundancy to the triage eval suite. The case presents a comprehensive, self-evident bug report where the reporter has already identified the root cause, affected files, and suggested fix. The triage_expectations penalize comments that restate what the reporter already wrote and reward comments focused on net-new value (test cases, secondary findings). This exercises the anti-redundancy rule added to agents/triage.md in this PR, giving the LLM judge a concrete rubric to evaluate whether the triage agent omits redundant commentary on self-evident issues. Addresses review feedback on #429
🔧 Fix agent — iteration 2 (human-triggered)Added triage eval case 007-self-evident-bug-redundancy to test the anti-redundancy rule. The case presents a comprehensive bug report where the reporter has already identified root cause, files, and fix. The LLM judge rubric rewards concise net-new-value comments and penalizes restated summaries. Fixed (1):
Tests: passed Updated by fullsend fix agent |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 9:10 AM UTC · Completed 9:22 AM UTC |
|
🤖 Finished Retro · ✅ Success · Started 6:56 AM UTC · Completed 7:08 AM UTC |
Retro: PR #429 — instruct triage agent to omit redundant commentaryOverall assessment: This was a clean, well-executed workflow. The code agent produced a surgical first pass, the review agent caught a legitimate ambiguity issue, and the fix agent addressed it effectively. One improvement opportunity identified. Timeline
What went well
Existing issue evidence
Proposals filed
|
Add parenthetical note distinguishing comment content conciseness from structured-field completeness. The triage_summary object fields must always be fully populated regardless of issue clarity. Addresses review feedback on #429
Add case 007-self-evident-bug-redundancy to the triage eval suite. The case presents a comprehensive, self-evident bug report where the reporter has already identified the root cause, affected files, and suggested fix. The triage_expectations penalize comments that restate what the reporter already wrote and reward comments focused on net-new value (test cases, secondary findings). This exercises the anti-redundancy rule added to agents/triage.md in this PR, giving the LLM judge a concrete rubric to evaluate whether the triage agent omits redundant commentary on self-evident issues. Addresses review feedback on #429
Add parenthetical note distinguishing comment content conciseness from structured-field completeness. The triage_summary object fields must always be fully populated regardless of issue clarity. Addresses review feedback on fullsend-ai#429
Add case 007-self-evident-bug-redundancy to the triage eval suite. The case presents a comprehensive, self-evident bug report where the reporter has already identified the root cause, affected files, and suggested fix. The triage_expectations penalize comments that restate what the reporter already wrote and reward comments focused on net-new value (test cases, secondary findings). This exercises the anti-redundancy rule added to agents/triage.md in this PR, giving the LLM judge a concrete rubric to evaluate whether the triage agent omits redundant commentary on self-evident issues. Addresses review feedback on fullsend-ai#429
Summary
agents/triage.md. The agent must now check whether the issue body or prior comments already convey a point before including it in the triage comment. Self-evident issues should receive minimal commentary focused on net-new value (related issues, test cases, severity, information gaps) rather than a full structured summary restating what the reporter already wrote.commentfield description in thesufficientaction's JSON schema example to reinforce the same principle — focus on information not already present in the issue body.Context
Issue #428 reports that the triage agent produces verbose comments (~40 lines) that restate information already present in the issue body, adding zero net-new information. The existing "Do NOT echo back raw text" rule (line 338) addresses injection safety but not content redundancy. This change adds the missing behavioral constraint.
Testing
prerequisites-creates-allowed-issue) reproduces identically on the base branch and is unrelated to this change.Closes #428
Post-script verification
agent/428-triage-no-repeat)e3293716ee87a1b1a6d07a403ccdeba4d724c9b9..HEAD)