fix(#407): add API fallback when pre-fetched review body is empty - #408
Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
Closed
fix(#407): add API fallback when pre-fetched review body is empty#408fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
When review-body.txt is empty (e.g., because the review agent posted a COMMENT review rather than CHANGES_REQUESTED), the fix-review skill now falls back to fetching the review bot's issue comment via the GitHub API. The fallback searches for comments from users matching *-review[bot] that contain the <!-- fullsend:review-agent --> marker, and uses the latest matching comment as the review body. This is defense-in-depth — it makes the fix agent self-healing regardless of the review body pre-fetch mechanism, without replacing the platform-level fix tracked in fullsend#4675. Closes #407
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. It will be closed in 2 weeks if no further activity occurs. Remove the |
|
This pull request has been closed due to inactivity. Feel free to reopen it if the changes are still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/fix-review/SKILL.mdstep 2a with a concrete GitHub API fetch that recovers review findings whenreview-body.txtis emptyCOMMENTrather thanCHANGES_REQUESTED), the fix agent now fetches the review bot's issue comment viagh api, filtering for the<!-- fullsend:review-agent -->markerContext
On PR #157, the review agent posted a COMMENT review. The pre-fetch jq filter only matched
CHANGES_REQUESTED, soreview-body.txtwas empty. The fix agent had no recovery path and wasted ~7 minutes before producing a no-op result. This change makes the fix agent self-healing, independent of the platform-level fix tracked in fullsend-ai/fullsend#4675.Test plan
/fs-fixon a PR where the review agent posted aCOMMENTreview (notCHANGES_REQUESTED) — the fix agent should recover findings via the API fallback and log::notice::Recovered review findings from issue comment API fallback/fs-fixon a PR where the review agent posted aCHANGES_REQUESTEDreview — the pre-fetched file should be used as before (no fallback triggered)/fs-fixon a PR with no review bot comment — the fix agent should log::error::No review body foundand proceed with existing behaviorCloses #407
Post-script verification
agent/407-fix-review-api-fallback)2dc5dc661767d79efb73179d1ca4dbd104c27c27..HEAD)