feat: add release workflow for version tag sync - #25
Conversation
Triggered when fullsend's release workflow pushes a semver tag to this repo. Creates a GitHub Release and moves the v0 floating tag, mirroring fullsend's release process. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
PR Summary by QodoAdd GitHub Actions release workflow to sync GitHub Releases and v0 tag
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
🤖 Finished Review · ✅ Success · Started 2:16 PM UTC · Completed 2:29 PM UTC |
Code Review by Qodo
Context used✅ Compliance rules (platform):
55 rules 1.
|
ReviewSince the prior review ( FindingsMedium
Low
Previous runReviewVerdict: Approve This PR adds a well-constructed release workflow triggered by semver tag pushes, along with comprehensive documentation in AGENTS.md and a new README.md. The workflow logic is correct: idempotent release creation, safe v0 floating tag movement with All prior review findings from the first pass have been addressed:
Two low-severity consistency issues remain. FindingsLow
Labels: PR adds CI release workflow and repository documentation Previous runReviewFindingsHigh
Medium
Low
Labels: PR adds README.md and updates AGENTS.md with versioning/release documentation alongside the workflow Previous runReviewVerdict: Approve This PR adds a well-constructed release workflow triggered by semver tag pushes, along with comprehensive documentation in AGENTS.md and a new README.md. The workflow logic is correct: idempotent release creation, safe v0 floating tag movement with All prior review findings from the first pass have been addressed:
Two low-severity consistency issues remain. FindingsLow
Labels: PR adds CI release workflow and repository documentation Previous run (2)ReviewFindingsHigh
Medium
Low
|
- Rename release.yml to release.yaml for consistency with fullsend.yaml - Add concurrency group to serialize release runs - Add inline comment justifying contents:write permission - Document versioning, release sync, workflow roles, and v0 tag in AGENTS.md Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
|
Addressing all findings from the review: High: protected-path — Linked to #26 which authorizes this change. Medium: missing-doc — Added §6 "Versioning and releases" to AGENTS.md documenting the release sync, what version tags mean in this repo, and the v0 floating tag. Low: missing-authorization — Linked to #26. Low: architectural-coherence — AGENTS.md §6 now documents the distinction: Low: missing-doc (v0 tag) — Documented in AGENTS.md §6. Low: file-extension-consistency — Renamed Low: edge-case (concurrency) — Added All fixes in f08f6a9. |
|
🤖 Review · |
Both repos should use the same filename for the release workflow. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
|
🤖 Review · |
Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 2:45 PM UTC · Completed 2:55 PM UTC |
The release workflow file is release.yml, not release.yaml. Signed-off-by: Greg Allen <greg@fullsend.ai> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
|
Addressing the two remaining low findings: doc-accuracy — Fixed in 24eef7e: updated AGENTS.md §6 to reference file-extension-consistency — Won't fix. Keeping |
|
🤖 Finished Review · ✅ Success · Started 3:26 PM UTC · Completed 3:40 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 5:08 PM UTC · Completed 5:18 PM UTC |
|
PR #25 added a release workflow for version tag sync to fullsend-ai/agents. The review agent ran 5 times (3 completed, 2 cancelled) and produced well-targeted findings that drove real improvements: protected-path authorization, missing documentation, missing issue link, and missing concurrency group. The human reviewer approved with only "LGTM", adding no findings beyond what the agents caught. However, a low-severity file-extension-consistency finding caused a rename → revert → doc-fix cascade that consumed 3 of 4 remediation commits, introduced a documentation accuracy bug, and triggered 2 cancelled review runs. The root cause: the style sub-agent lacked cross-repo context — the author chose Proposals filed |
Summary
release.ymlworkflow triggered on semver tag pushes (v*.*.*)v0floating tag for non-prerelease versions (same logic as fullsend)Closes #26
Context
Tags are pushed to this repo by fullsend's release workflow after GoReleaser succeeds. This workflow handles the agents-side response: creating the GitHub Release and moving v0.
Companion PR: fullsend-ai/fullsend#3079
Test plan
fullsend-ai/fullsend🤖 Generated with Claude Code