Skip to content

fix(#170): remove inert disallowedTools from agent definitions - #171

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/170-remove-disallowed-tools
Jul 16, 2026
Merged

fix(#170): remove inert disallowedTools from agent definitions#171
rh-hemartin merged 1 commit into
mainfrom
agent/170-remove-disallowed-tools

Conversation

@fullsend-ai-coder

@fullsend-ai-coder fullsend-ai-coder Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Remove disallowedTools frontmatter from agents/code.md, agents/fix.md, agents/review.md, and agents/retro.md. These entries are inert in --agent sessions (per ADR [balkov] EDIT: 0027 0024) and Bash(...) entries trigger a Claude Code bug that removes the entire Bash tool, causing costly subagent fallbacks.

Also remove the inert tools key from agents/review.md and agents/retro.md.

Update comments in harness, env, policy, and skill files to reference the actual enforcement mechanisms: sandbox token scoping (read-only GH_TOKEN), PUSH_TOKEN isolation, and network policy binary allowlists.


Closes #170

Post-script verification

  • Branch is not main/master (agent/170-remove-disallowed-tools)
  • Secret scan passed (gitleaks — 0dbf1959357382ecdb9bb39e3c69a5fa678af3c1..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

@ben-alkov ben-alkov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maruiz93 maruiz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff against the RCA findings (discussion fullsend-ai/fullsend#5182) and Ben's experimentation on fullsend#4437 confirming that tools: scoping (e.g. Bash(gh)) grants full Bash access — so retro.md's Bash(gh,jq) restriction was cosmetic.

Agent frontmatter removal is correct across all four files. Comment updates in harness, env, policies, and skill accurately describe the real enforcement mechanisms (token scoping, PUSH_TOKEN isolation, binary allowlists). SKILL.md rationale change for --amend is sound.

Remove disallowedTools frontmatter from agents/code.md,
agents/fix.md, agents/review.md, and agents/retro.md.
These entries are inert in --agent sessions (per ADR 0024)
and Bash(...) entries trigger a Claude Code bug that removes
the entire Bash tool, causing costly subagent fallbacks.

Also remove the inert tools key from agents/review.md and
agents/retro.md.

Update comments in harness, env, policy, and skill files
to reference the actual enforcement mechanisms: sandbox
token scoping (read-only GH_TOKEN), PUSH_TOKEN isolation,
and network policy binary allowlists.

Closes #170
@rh-hemartin
rh-hemartin force-pushed the agent/170-remove-disallowed-tools branch from e40c946 to f930a5f Compare July 16, 2026 15:25
@rh-hemartin
rh-hemartin added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 1b217bd Jul 16, 2026
11 checks passed
@rh-hemartin
rh-hemartin deleted the agent/170-remove-disallowed-tools branch July 16, 2026 15:39
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 16, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 3:41 PM UTC · Completed 3:49 PM UTC
Commit: f930a5f · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

PR #171 (fix: remove inert disallowedTools from agent definitions) was a clean, single-iteration code agent run that completed in 7m36s with no rework needed. The code agent correctly identified and modified all 14 affected files across agent definitions, harness configs, policies, env files, and the code-implementation skill. Three human reviewers approved with no inline change requests, and the PR was merged ~2 days later. Three workflow issues were identified: (1) the review agent never dispatched because the post-code script failed to apply the ready-for-review label (already tracked in #199), (2) the triage agent inappropriately applied a blocked label during re-triage while the implementing PR was already open, and (3) the code agent propagated an incorrect ADR reference from the issue body into its PR description, requiring human correction.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: remove disallowedTools from all agents/*.md files

4 participants