Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion skills/pr-review/sub-agents/correctness.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,25 @@ identifier (enum value, label name, config key, action type, function
name, CLI flag), grep the full repository — source code, scripts,
configs, and workflows — for remaining references to the old name.
Exclude the files already in the diff. Any hit outside the diff is a
Medium-severity finding: "stale reference to removed/renamed
medium-severity finding: "stale reference to removed/renamed
`<identifier>` in `<file>:<line>`."

### CI coverage regression severity

When a change reduces which file paths trigger CI checks (e.g.,
replacing a broad path filter with a narrower selection mechanism),
evaluate the merge-gate impact:

- **high** if the regression removes merge-queue or PR-gate signal for
a class of changes that previously received it. Changes to shared
Comment thread
ben-alkov marked this conversation as resolved.
infrastructure (CI scripts, test runners, config files) landing
without CI signal is a high-severity coverage regression.
- **medium** if the regression only affects optional or advisory checks
that do not gate merging.

The key question: "Can a PR touching these paths now land on main
without the CI checks that previously guarded them?" If yes, rate high.

### Technical documentation with correctness surface area

Not all documentation is prose. Any
Expand Down
Loading