Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose parameteres with default values #17

Closed
leolobato opened this issue Nov 8, 2016 · 7 comments
Closed

Expose parameteres with default values #17

leolobato opened this issue Nov 8, 2016 · 7 comments

Comments

@leolobato
Copy link
Contributor

It might be useful to expose the parameters currently defined as private (e.g. TOTAL_TIMEOUT_SECONDS) for configuring the recorder according to the app's needs.

@fulldecent
Copy link
Owner

Agreed, yes.

Also, they need better Swifty names.

@fulldecent
Copy link
Owner

f9bfe73 adds proposed names and documentation for these parameters.

I'd like to have them right before making that API public.

@fulldecent
Copy link
Owner

What does everyone think about the existing names?

@leolobato
Copy link
Contributor Author

leolobato commented Feb 2, 2017

Added a couple of notes at the commit. Looks good to me, except for the "sampleRate" parameter.

I'm not sure if the "intervals" concept will be immediately clear to someone looking into tweaking the parameters, but I see it might be simpler than specifying ms for each of the parameters being tweaked.

@fulldecent
Copy link
Owner

The issue is that tweaking ms for each parameter is incompatible with our implementation.

@fulldecent
Copy link
Owner

Perhaps there is a way I can improve that documentation.

@fulldecent
Copy link
Owner

Thank you, just exposed this in a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants