-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose parameteres with default values #17
Comments
Agreed, yes. Also, they need better Swifty names. |
f9bfe73 adds proposed names and documentation for these parameters. I'd like to have them right before making that API public. |
What does everyone think about the existing names? |
Added a couple of notes at the commit. Looks good to me, except for the "sampleRate" parameter. I'm not sure if the "intervals" concept will be immediately clear to someone looking into tweaking the parameters, but I see it might be simpler than specifying ms for each of the parameters being tweaked. |
The issue is that tweaking ms for each parameter is incompatible with our implementation. |
Perhaps there is a way I can improve that documentation. |
Thank you, just exposed this in a new release |
It might be useful to expose the parameters currently defined as private (e.g.
TOTAL_TIMEOUT_SECONDS
) for configuring the recorder according to the app's needs.The text was updated successfully, but these errors were encountered: