test(codec): assert the bases the codec_template consensus tests are named for

[nh13]

Closes #807.

What

Two CODEC tests added with #767 assert only the consensus length, under a codec_template doc comment that still claimed the bases were unusable and pointed at #763. #768 (the fix for #763) stores the reverse CODEC read in reference orientation, so codec_template families now consense to the reference sequence over the region the two strands share — not the mostly-N output the create_fr_pair orientation bug used to produce. This makes those tests assert the bases they are named for, and corrects the stale doc.

Changes

• test_dovetailed_starts_without_an_indel_call_a_consensus — now asserts the 128 emitted consensus bases (was length-only).
• test_terminal_indel_outside_the_shared_region_calls_a_consensus — now asserts the 127 emitted consensus bases (was length-only).
• Corrected the codec_template doc comment (removed the false "consensus comes out mostly N … Tracked as codec caller test fixture stores the reverse read's SEQ in read orientation, so its consensus is almost all N #763" rationale).

The two sibling codec_template tests are appropriate as-is: test_min_duplex_length_is_measured_over_the_shared_region is a threshold test and test_indel_inside_the_shared_region_is_still_rejected rejects (no bases to assert).

Verification

Each new expected literal was verified byte-for-byte against REF_BASES, not merely captured from the code:

• dovetail (128): the body after the 2-base soft-clip edge equals REF_BASES[200..326] exactly (0 non-N mismatches, 0 Ns in the body).
• terminal-indel (127): the body equals the reference over the shared span with the terminal deletion skipped (0 non-N mismatches); the lone N is the single-strand edge past the reverse read's close.

Test-only; no production change. cargo nextest run -p fgumi-consensus (1267 passed), cargo fmt --check, and cargo clippy -p fgumi-consensus --all-targets all clean.

[coderabbitai]

Note

Reviews paused

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 99a9b54d-f292-4024-a171-4a070c165e9b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[nh13]

@coderabbitai pause

[coderabbitai]

✅ Action performed

Reviews paused.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.30%. Comparing base (257dedf) to head (0b60b38).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         186      186           
  Lines      112550   112554    +4     
=======================================
+ Hits       106136   106141    +5     
+ Misses       6414     6413    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.