Repository navigation
test(codec): read stats as fgbio KV metrics in pre-group-filter test - #585
Conversation
test_codec_allow_unmapped_gates_pregroup_filter parsed the codec stats file as a wide ConsensusMetrics TSV, but codec emits fgbio's vertical key-value format (ConsensusKvMetric). The header mismatch made read_tsv fail with "Error parsing delimited data file header" in all four cases. The break was a semantic merge conflict: #513 switched codec stats to the KV format, then #509 (merged after) added this test using the old wide layout. Both merged cleanly textually, so the failure only surfaced on the merged main tip. Read the rows back as ConsensusKvMetric and look up the counts by key (raw_reads_considered, consensus_reads_emitted), mirroring the sibling simplex tests. The assertions' intent is unchanged: the supplementary alignment is filtered before grouping (2 raw reads considered) and the single FR molecule is emitted (1 consensus read).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe codec integration test now parses ChangesCodec stats validation
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
- Coverage 92.69% 92.68% -0.02%
==========================================
Files 166 166
Lines 100549 100719 +170
==========================================
+ Hits 93205 93348 +143
- Misses 7344 7371 +27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
test_codec_allow_unmapped_gates_pregroup_filterparsed the codec stats file as a wideConsensusMetricsTSV, butcodecemits fgbio's vertical key-value format (ConsensusKvMetric). The header mismatch maderead_tsvfail withError parsing delimited data file headerin all four cases (fast-path/threaded × default/allow-unmapped), failingtestandcoverageonmain.This was a semantic merge conflict, not a code regression: #513 switched codec stats to the KV format, then #509 (merged after) added this test against the old wide layout. Both merged cleanly as text, so the break only surfaced on the merged
maintip — which is why the release PR (#454) and branches rebased on it (#519, #527) all inherit the same four failing cases.The fix reads the rows back as
ConsensusKvMetricand looks up the counts by key (raw_reads_considered,consensus_reads_emitted), mirroring the siblingsimplextests. The assertions' intent is unchanged: the supplementary alignment is filtered before grouping (2 raw reads considered) and the single FR molecule is emitted (1 consensus read).Verified locally: all four cases pass; full
codecmodule green;fmtandclippy --all-targets -D warningsclean.Summary by CodeRabbit
--statstab-separated output format.