Repository navigation
docs(consensus): fix stale module-example paths and declare them non-code - #579
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughUpdated consensus crate documentation examples to use ChangesConsensus documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 92.96% 92.99% +0.03%
==========================================
Files 167 167
Lines 103266 103266
==========================================
+ Hits 96000 96034 +34
+ Misses 7266 7232 -34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c69253d to
084588b
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
084588b to
bdeede0
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
…non-code The `//!` module-doc walkthroughs in base_builder/caller/codec_caller/duplex_caller were fenced ```rust,ignore` — rendered as Rust but never compiled — and had rotted: they imported from the old monolith path `fgumi_lib::consensus::...` (the crate is now `fgumi_consensus`) and referenced the since-renamed `vanilla_consensus_caller` module (now `vanilla_caller`). So they showed readers import paths that don't exist, with nothing to catch it. These are genuine teaching sketches — undefined context vars (`reads`, `options`, `output`, ...), elided bodies, trait-shape skeletons — so they can't be compiled without gutting their clarity. Rather than leave them masquerading as verified Rust: - correct the crate paths (`fgumi_consensus::...`) and the `vanilla_caller` rename, including the prose "See Also" cross-references, so what's shown is accurate; and - change the fences to ```text`, honestly declaring them as illustrative rather than as Rust the doctest/rustdoc gates would be expected to check. Verified: introduces zero new rustdoc warnings vs main (the crate's remaining broken intra-doc links are fixed by the sibling PR #574).
bdeede0 to
7a247a6
Compare
Closes the last "ungated doc claim" from the audit (task-list T5).
Problem
The
//!module-doc walkthroughs infgumi-consensus(base_builder,caller,codec_caller,duplex_caller) were fenced```rust,ignore— rendered as Rust but never compiled — and had rotted: they import from the old monolith pathfgumi_lib::consensus::...(the crate is nowfgumi_consensus) and reference the renamedvanilla_consensus_callermodule (nowvanilla_caller). Readers were shown import paths that don't exist, with no gate to catch it. #574 explicitly deferred these because its rustdoc gate doesn't coverignoreblocks.Fix
These are genuine teaching sketches (undefined context vars, elided bodies, trait-shape skeletons), so they can't compile without gutting their clarity. Rather than leave them masquerading as verified Rust:
fgumi_consensus::…) and thevanilla_callerrename, including the prose "See Also" cross-references, so what's shown is accurate; and```text, honestly declaring them illustrative rather than as Rust the gates would be expected to verify.This is the "declare as non-code" side of the fix — the principled resolution for examples that legitimately can't be compiled. (Full
#-hidden compilable doctests are possible but would clutter the teaching examples with boilerplate; deferred as optional.)Verification
RUSTDOCFLAGS="-D warnings" cargo doc -p fgumi-consensusproduces the identical error set as pristine main — i.e. this PR introduces zero new rustdoc warnings. The crate's remaining broken intra-doc links (rejected_reads/take_rejected_reads) are fixed by the sibling PR #574; once #573/#574/this all land, the crate doc-builds clean under the rustdoc gate.Summary by CodeRabbit