Skip to content

refactor(consensus,correct): migrate hand-rolled rejects writers to first-class secondary_output - #332

Merged
nh13 merged 7 commits into
mainfrom
nh/issue-329-rejects-secondary-output
May 16, 2026
Merged

nh13 merged 7 commits into
mainfrom
nh/issue-329-rejects-secondary-output

review: address deep review findings on issue-329 migration

5cd9d1a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 16, 2026 in 1s

90.87% (+0.08%) compared to abcb8e6

View this Pull Request on Codecov

90.87% (+0.08%) compared to abcb8e6

Details

Codecov Report

❌ Patch coverage is 92.07048% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.87%. Comparing base (abcb8e6) to head (5cd9d1a).

Files with missing lines Patch % Lines
src/lib/commands/common.rs 87.69% 8 Missing ⚠️
src/lib/commands/duplex.rs 93.16% 8 Missing ⚠️
src/lib/commands/codec.rs 92.04% 7 Missing ⚠️
src/lib/unified_pipeline/bam.rs 73.07% 7 Missing ⚠️
src/lib/commands/correct.rs 89.13% 5 Missing ⚠️
src/lib/commands/simplex.rs 99.08% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   90.79%   90.87%   +0.08%     
==========================================
  Files          78       78              
  Lines       50801    50775      -26     
==========================================
+ Hits        46124    46143      +19     
+ Misses       4677     4632      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.