Skip to content

Remove unused --sort-order flag from codec and simplex - #209

Merged
nh13 merged 1 commit into
mainfrom
nh/fix_codec-consensus-calling
Mar 31, 2026
Merged

nh13 merged 1 commit into
mainfrom
nh/fix_codec-consensus-calling

Conversation

@nh13

@nh13 nh13 commented Mar 31, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Removes the --sort-order / -S CLI argument from codec and simplex consensus callers
  • The flag was defined but never wired through — the output header is hardcoded to SO:unknown in create_unmapped_consensus_header(), so passing --sort-order Queryname silently did nothing
  • duplex never had this flag; clip's --sort-order is functional and unaffected

Test plan

  • cargo ci-test — 1998 tests pass
  • cargo ci-fmt — clean
  • cargo ci-lint — clean
  • Verified fgumi codec --help and fgumi simplex --help no longer show --sort-order

The --sort-order / -S argument was defined on both codec and simplex
commands but never wired through to the output header, which is
hardcoded to SO:unknown. Passing --sort-order Queryname silently
did nothing, misleading users into thinking their output was sorted.

Removes the dead flag from both commands. Duplex never had it.
The clip command's --sort-order is functional and unaffected.
@nh13
nh13 temporarily deployed to github-actions March 31, 2026 05:41 — with GitHub Actions Inactive
@nh13
nh13 marked this pull request as ready for review March 31, 2026 05:42
@nh13

nh13 commented Mar 31, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@codecov

codecov Bot commented Mar 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.06%. Comparing base (91e5af6) to head (ce498f8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files         113      113           
  Lines       52795    52818   +23     
=======================================
+ Hits        46495    46516   +21     
- Misses       6300     6302    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 647fa629-74b2-4423-8ea5-7dde871472a5

📥 Commits

Reviewing files that changed from the base of the PR and between 90ec6fe and ce498f8.

📒 Files selected for processing (2)
  • src/commands/codec.rs
  • src/commands/simplex.rs
💤 Files with no reviewable changes (2)
  • src/commands/codec.rs
  • src/commands/simplex.rs

📝 Walkthrough

Walkthrough

The sort_order CLI option (-S/--sort-order) was removed from multiple command structures. This involved deleting the pub sort_order: Option<String> field from affected command structs and updating their corresponding test helper functions to no longer initialize this field. No other code paths or runtime behavior depend on this removed option.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly describes the main change—removing the unused --sort-order flag from codec and simplex commands.
Description check ✅ Passed Description is directly related to the changeset, explaining why the flag was removed, what issue it caused, and confirmation that tests pass.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nh/fix_codec-consensus-calling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nh13
nh13 merged commit 53463ca into main Mar 31, 2026
7 checks passed
@nh13
nh13 deleted the nh/fix_codec-consensus-calling branch March 31, 2026 05:48
@nh13 nh13 mentioned this pull request Mar 31, 2026

This branch was previously deployed

1 inactive deployment
github-actions — ce498f80 Deployed Mar 31, 2026 by nh13 via coverage #784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant