Repository navigation
Remove unused --sort-order flag from codec and simplex - #209
Conversation
The --sort-order / -S argument was defined on both codec and simplex commands but never wired through to the output header, which is hardcoded to SO:unknown. Passing --sort-order Queryname silently did nothing, misleading users into thinking their output was sorted. Removes the dead flag from both commands. Duplex never had it. The clip command's --sort-order is functional and unaffected.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 113 113
Lines 52795 52818 +23
=======================================
+ Hits 46495 46516 +21
- Misses 6300 6302 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
--sort-order/-SCLI argument fromcodecandsimplexconsensus callersSO:unknownincreate_unmapped_consensus_header(), so passing--sort-order Querynamesilently did nothingduplexnever had this flag;clip's--sort-orderis functional and unaffectedTest plan
cargo ci-test— 1998 tests passcargo ci-fmt— cleancargo ci-lint— cleanfgumi codec --helpandfgumi simplex --helpno longer show--sort-order