Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose a scalafmt configuration that applies Nils and Tim's preferred conventions #1001

Open
msto opened this issue Jul 15, 2024 · 1 comment
Assignees
Labels

Comments

@msto
Copy link
Contributor

msto commented Jul 15, 2024

fgbio PRs are expected to adhere to "tim-format," which encompasses Nils and Tim's preferred conventions for formatting Scala code.

e.g. #958 (comment)

The conventions encompassed by "tim-format" should be documented somewhere in the repository, e.g. in a CONTRIBUTING.md. Additionally, a scalafmt configuration should be composed that automatically applies these formatting conventions. (This configuration should also be adopted in Fulcrum's other Scala repos, including private client repos.)

@msto msto assigned nh13 and tfenne Jul 15, 2024
@nh13
Copy link
Member

nh13 commented Jul 15, 2024

Thanks @msto. Given the limited time we're spending developing fgbio, this one will likely go unworked on. I am not sure it's even possible with scalfmt. But I am glad we're calling it out.

@nh13 nh13 added the wontfix label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants