This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add a global configuration option to control when to fall back to system #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paths when configuring an executable.
nh13
commented
May 28, 2019
| @@ -165,25 +166,40 @@ private[config] trait ConfigurationLike extends LazyLogging { | |||
| } | |||
| } | |||
|
|
|||
| /** True to fall back to the searching the system path when a configuration key exists but the executable does not. | |||
| * False to throw an exception if the configuration key exists but the executable does not. */ | |||
| private def fallBackToSystemPath: Boolean = configure(Configuration.Keys.FallBackToSystemPath, false) | |||
There was a problem hiding this comment.
I have to think about if this could be a lazy val (i.e. is config immutable)
clintval
reviewed
May 29, 2019
| val SystemCores = "dagr.system-cores" | ||
| val SystemMemory = "dagr.system-memory" | ||
| val PrintArgs = "dagr.print-args" | ||
| val FallBackToSystemPath = "dagr.fall-back-to-system-path" |
There was a problem hiding this comment.
fall-back-to-system-path-for-missing-executables
?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paths when configuring an executable.
Alternate implementation to #348