This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
New Exec system #278
Closed
New Exec system #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh13
force-pushed
the
nh_exec2
branch
12 times, most recently
from
April 9, 2017 07:34
afe895b
to
e652d9b
Compare
nh13
commented
Apr 9, 2017
} | ||
} | ||
|
||
class ExecutorImpl(protected val taskExecutor: TaskExecutor) extends Executor with LazyLogging { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using Future
s for callbacks, and I am a bit of a novice here. But I think the idea is sound.
nh13
commented
Apr 9, 2017
|
||
// Execute the task | ||
val executeFuture: Future[TaskHandler] = submitFuture flatMap { handler: TaskHandler => | ||
// TODO: apply the resources it was scheduled with: task.applyResources(resources) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no long relevant
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 91.38% 92.19% +0.81%
==========================================
Files 31 42 +11
Lines 1137 1537 +400
Branches 106 127 +21
==========================================
+ Hits 1039 1417 +378
- Misses 98 120 +22
Continue to review full report at Codecov.
|
nh13
force-pushed
the
nh_exec2
branch
12 times, most recently
from
May 15, 2017 09:00
788d6dd
to
063dee4
Compare
nh13
force-pushed
the
nh_exec2
branch
2 times, most recently
from
May 19, 2017 07:01
5f62c83
to
a19fe7f
Compare
nh13
force-pushed
the
nh_exec2
branch
2 times, most recently
from
May 19, 2017 08:01
d7806c2
to
63b65b5
Compare
@tfenne I think this is finally ready for review! |
nh13
force-pushed
the
nh_exec2
branch
3 times, most recently
from
June 6, 2017 21:01
dac06fd
to
e4e7933
Compare
Closing in favor of: #299 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfenne I think this is now achieves feature parity with the current execution system. I added an option
--experimental-execution
to enable the new task system. Interactive mode, final reports, and status logging are supported, though the latter is substantially different (and more verbose). I have tested it on some simple workflows (see one example below). I have a a lot of cleanup to complete on the actual code, as well as likely a bunch more tests, but I am very pleased with the progress. After cleanup, I think I am ready to add in "replay".