-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SystemUtil for querying common system properties #59
Conversation
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
+ Coverage 93.21% 93.5% +0.28%
=========================================
Files 24 25 +1
Lines 825 831 +6
Branches 55 59 +4
=========================================
+ Hits 769 777 +8
+ Misses 56 54 -2
Continue to review full report at Codecov.
|
@clintval what do you think about these changes? https://github.com/clintval/commons/pull/1. I'm happy to update fgbio and dagr for you. |
A+ go for it. Was going to write tests after the public API was revealed, but thanks for beating me to it! |
b6133c5
to
53cf1d3
Compare
src/main/scala/com/fulcrumgenomics/commons/util/SystemUtil.scala
Outdated
Show resolved
Hide resolved
@nh13, all set. I found a way to have anchored regex matching that is 2.12 and 2.13 compatible. Ping me if you want help with the rest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be interested in seeing this merged as I want to factor this into PicardTask
in Dagr.
src/main/scala/com/fulcrumgenomics/commons/util/SystemUtil.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/fulcrumgenomics/commons/util/SystemUtil.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggested change you yourself suggested.
src/main/scala/com/fulcrumgenomics/commons/util/SystemUtil.scala
Outdated
Show resolved
Hide resolved
124a1e5
to
9c0ad0b
Compare
Few changes:
|
@nh13 I think this is merge-ready FYI |
If possible, I'd like to find a way to move this along because I also want to use these features for patches to |
Functionality pulled from
fgbio
anddagr
.Which of these would you like as a part of public API?