Mimic ql-minitar's handling of unusual tarball entries. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archive signals an error for unknown tarball entry types (including relatively common ones like symlinks), while quicklisp's own ql-minitar generally just ignores unknown entries. Since archive appears to be less than actively maintained, mimic ql-minitar's behavior by overriding the read method for tarballs read by qlot. This is accomplished by creating a subclass of ARCHIVE:TAR-ARCHIVE and coercing opened archives to that class. A customized READ-ENTRY-FROM-ARCHIVE method then handles reading tarball entries without throwing an error, so that unexpected entry types can be skipped. Other users of archive in the same image will not be affected, since they won't be using the subclass. There is a maintenance risk here, since the implementation of READ-ENTRY-FROM-ARCHIVE is more-or-less copied from archive, and uses a slew of unexported symbols. However, archive does not appear to be actively developed, even by the sharplisper group that adopted it, so the odds of this being an issue are small. This change allows qlot to patch the read behavior without having to get changes upstreamed into archive. This implementation handles everything that ql-minitar does, plus some extras provided by archive, with the sole exception of POSIX extended headers.
mtstickney
force-pushed
the
symlink_handling
branch
from
e8e1e59
to
0b5fea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
archivesignals an error for unknown tarball entry types (includingrelatively common ones like symlinks), while quicklisp's own
ql-minitar generally just ignores unknown entries. Since archive
appears to be less than actively maintained, mimic ql-minitar's
behavior by overriding the read method for tarballs read by qlot.
This is accomplished by creating a subclass of
tar-archiveandcoercing opened archives to that class. A customized
read-entry-from-archivemethod then handles reading tarball entrieswithout throwing an error, so that unexpected entry types can be
skipped. Other users of archive in the same image will not be
affected, since they won't be using the subclass.
There is a maintenance risk here, since the implementation of
read-entry-from-archiveis more-or-less copied from archive, and usesa slew of unexported symbols. However, archive does not appear to be
actively developed, even by the sharplisper group that adopted it, so
the odds of this being an issue are small. This change allows qlot to
patch the read behavior without having to get changes upstreamed into
archive.
This implementation handles everything that ql-minitar does, plus some
extras provided by archive, with the sole exception of POSIX extended
headers.