Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tui): add Turkish (tr) locale #1330

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat(tui): add Turkish (tr) locale #1330

merged 1 commit into from
Oct 4, 2024

Conversation

fujiapple852
Copy link
Owner

No description provided.

@fujiapple852 fujiapple852 mentioned this pull request Oct 2, 2024
3 tasks
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
crates/trippy-tui/locales/app.yml Outdated Show resolved Hide resolved
@fujiapple852 fujiapple852 force-pushed the feat-i18n-tr branch 2 times, most recently from 79466d5 to f15865f Compare October 4, 2024 09:10
@fujiapple852
Copy link
Owner Author

All LGTM, thanks!

Here is how the header looks:

╭───────────────────────────────────────────────────────────────── trippy v0.12.0-dev ──────────────────────────────────────────────────────────────────╮
│Hedef: 192.168.1.21 (192.168.1.21) -> 1.1.1.1 (1.1.1.1)                                                                       2024-10-04T17:12:41+08:00│
│Konfigurasyon: protokol=icmp(v4, ayrıcalıksız) AS Bilgi=açık ayrıntılar=kapalı maksimum hostlar=otomatik, gizlilik=kapalı       hYardım sAyarlar qÇıkış│
│Durum: Çalışıyor, 9 atlanan keşfedildi                                                                                                                 │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Vs en:

╭───────────────────────────────────────────────────────────────── trippy v0.12.0-dev ──────────────────────────────────────────────────────────────────╮
│Target: 192.168.1.21 (192.168.1.21) -> 1.1.1.1 (1.1.1.1)                                                                      2024-10-04T17:13:31+08:00│
│Config: protocol=icmp(v4, unprivileged) as-info=on details=off max-hosts=auto, privacy=off                                           help settings quit│
│Status: Running, discovered 9 hops                                                                                                                     │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

I think I need to rework the 2nd (Config) line to look better for languages which use multiple words for "as-info" and "max-hosts".

I also need to improve the help/settings/quit part on the right of that line for non-English languages.

But neither of these issues are specific to tr so don't block merging this PR.

Co-authored-by: Orhun Parmaksız <[email protected]>
@fujiapple852 fujiapple852 merged commit 6e0a32f into master Oct 4, 2024
20 checks passed
@fujiapple852 fujiapple852 deleted the feat-i18n-tr branch October 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants