Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invalid query error when using non-hosted graph #112

Conversation

modersohn
Copy link
Collaborator

* as described in fudgebucket27#50 - the non-hosted graphs don't like unused
  query parameters
* removed block from query completely, was never used
* if no typename is provided, delete the lines in the query
* added new tests for GetTransactions
@fudgebucket27
Copy link
Owner

There is an issue when going into the block details page. The transactions don't show up for the block and it has this error in the GetTransactions method in the LoopringGraphQLService class:

"{"errors":[{"locations":[{"line":7,"column":17}],"message":"Invalid value provided for argument whereFilter: Object({"typename": String("19525")})"}]}"

Looks like it's to do with the typename in the where filter

@fudgebucket27
Copy link
Owner

fudgebucket27 commented Apr 20, 2022

I've just pushed a fix for the block transactions not showing and added a new unit test for block transactions. i will merge this into dev and do some tests online. then will merge into master

@fudgebucket27 fudgebucket27 merged commit 5dfefad into fudgebucket27:dev Apr 20, 2022
@modersohn modersohn deleted the fix/TransactionsQueryWithNonHostedGraph branch April 23, 2022 11:28
@modersohn modersohn mentioned this pull request May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants